Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable7] Ext storage share key not updated after changing applicable users #11181

Closed
PVince81 opened this issue Sep 19, 2014 · 7 comments
Closed

Comments

@PVince81
Copy link
Contributor

Steps to reproduce

  1. Enable encryption
  2. Enable external storage
  3. Create two users "user1" and "user2"
  4. Mount a external storage as system mount point (for example "Local") and give access to "user1"
  5. Create a non-empty file "test.txt" inside
  6. Check the share keys inside of $datadir/files_encryption/share-keys, see that there is a key for "user1".
  7. Change access of the mount point, remove "user1" and add "user2"
  8. Check the keys again

Expected result

Share keys for "user1" are gone.
Share keys for "user2" exist.

Actual result

Share keys for "user1" still exist even though the user has no more access.
Share keys for "user2" are missing.

Versions

ownCloud 7 stable7 (7930440)

I talked with @schiesbn and he said there is no hook to find out whenever a mount point has changed, so it is currently not possible to detect such updates.

@PVince81
Copy link
Contributor Author

Would be cool if the external storage users were handled just like for shares, see proposal here: #11182

@PVince81
Copy link
Contributor Author

@MTRichards @craigpg FYI

@PVince81
Copy link
Contributor Author

@MTRichards I moved the "enhanced proposed" to the ticket that actually makes the proposal here: #11182

Let's keep this ticket here for bugfixing, in case we find a short term solution.

CC @karlitschek

@karlitschek
Copy link
Contributor

@schiesbn is this still open?

@PVince81
Copy link
Contributor Author

PVince81 commented Mar 1, 2016

Very likely to still be an issue even with 9.0 because we still don't have hooks for when applicables are changed. But hopefully with the revamped external storage code it should be much easier to add these. Setting to 9.1.

@PVince81 PVince81 added this to the 9.1-next milestone Mar 1, 2016
@schiessle
Copy link
Contributor

That's basically the same issue as if users are added to groups... We can't magically encrypt the files for new users. One solution is the master key.

@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants