Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ext storage] Consider moving to Flysystem #11263

Closed
PVince81 opened this issue Sep 23, 2014 · 5 comments
Closed

[ext storage] Consider moving to Flysystem #11263

PVince81 opened this issue Sep 23, 2014 · 5 comments

Comments

@PVince81
Copy link
Contributor

Flysystem is a library that can take care of abstracting external storage: http://flysystem.thephpleague.com/
https://github.com/thephpleague/flysystem

This way we don't need to maintain our own implementation of the connectors, but can still contribute upstream.

As you can see on the website it supports the following:

  • Local
  • AWS S3
  • Rackspace
  • Dropbox
  • Ftp
  • SFTP
  • Zip (??)
  • WebDAV

To evaluate:

  • how suitable it is for our use case
  • how much work is needed to fit this in
  • how its call/data caching works, whether we can use it as is or whether it duplicates what ownCloud's caching
  • whether it can properly detect updates done directly on the remote server (which is a common issue)

One problem is that it requires PHP >= 5.4 (according to composer https://github.com/thephpleague/flysystem/blob/master/composer.json#L16)
So as long as we need to support PHP 5.3 this won't be a solution.

@icewind1991 suggested that we could use it for the backends it needs and for everything else we can use the older mechanism.

@DeepDiver1975 @icewind1991 @schiesbn @LukasReschke @karlitschek @MTRichards @craigpg

@PVince81
Copy link
Contributor Author

And obviously when evaluating an external library:

  • whether it's well maintained / active project

@LukasReschke
Copy link
Member

I'd really appreciate this 👍

@th3fallen
Copy link
Contributor

i showed this to lukas a few weeks ago or months (time flys) i think it would be an amazing improvement. 👍

@PVince81
Copy link
Contributor Author

  • evaluate the performance: whether the lib is doing things we don't need (I see it has events!) that could slow down the performance
  • does the lib also support upload/download streaming instead of temp files ? (a feature we'd like to add)

@PVince81
Copy link
Contributor Author

PVince81 commented Aug 3, 2015

Flysystem was merged in core: #16923

@PVince81 PVince81 closed this as completed Aug 3, 2015
@MorrisJobke MorrisJobke modified the milestones: 8.2-current, backlog Sep 13, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants