-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ext storage] Consider moving to Flysystem #11263
Labels
Milestone
Comments
And obviously when evaluating an external library:
|
I'd really appreciate this 👍 |
i showed this to lukas a few weeks ago or months (time flys) i think it would be an amazing improvement. 👍 |
|
Flysystem was merged in core: #16923 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Flysystem is a library that can take care of abstracting external storage: http://flysystem.thephpleague.com/
https://github.com/thephpleague/flysystem
This way we don't need to maintain our own implementation of the connectors, but can still contribute upstream.
As you can see on the website it supports the following:
To evaluate:
One problem is that it requires PHP >= 5.4 (according to composer https://github.com/thephpleague/flysystem/blob/master/composer.json#L16)
So as long as we need to support PHP 5.3 this won't be a solution.
@icewind1991 suggested that we could use it for the backends it needs and for everything else we can use the older mechanism.
@DeepDiver1975 @icewind1991 @schiesbn @LukasReschke @karlitschek @MTRichards @craigpg
The text was updated successfully, but these errors were encountered: