Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use part files for web UI upload #13755

Closed
PVince81 opened this issue Jan 29, 2015 · 3 comments
Closed

Use part files for web UI upload #13755

PVince81 opened this issue Jan 29, 2015 · 3 comments
Labels

Comments

@PVince81
Copy link
Contributor

Steps to reproduce

  1. Prepare a bag full with luck
  2. Enable encryption
  3. Setup the sync client
  4. Upload a lot of small files with the Web UI
  5. While the Web UI is still uploading, the sync client will at some point start downloading

Expected result

No encryption error in log

Actual result

If you're (un-)luck, it might happen that the sync client sees a file while it is still being uploaded/encrypted, which results in the following:

{"reqId":"f88e81b5c643f29cba06d504d97b69b1","remoteAddr":"192.168.1.2","app":"remote","message":"Encryption key not found for \"\/root\/files\/sub10\/zegar.gif\" during attempted read via stream","level":4,"time":"2014-11-28T08:57:35+00:00"}

One solution for this would be to make files that are uploaded through the Web UI also become a part file at first, until all file operations, proxies, etc are finished (for encryption). Then at the end, rename the file to the final file.

Versions

OC 8 git master, possibly happening in any version

In general I think we should start using part files for everything related to upload.

@schiesbn @DeepDiver1975 @icewind1991

@PVince81
Copy link
Contributor Author

I forgot to mention that the sync client will show an error when downloading that incomplete file. The next sync run will redownload it and all is fine in the end.

@PVince81 PVince81 mentioned this issue Jan 29, 2015
22 tasks
@DeepDiver1975
Copy link
Member

In general I think we should start using part files for everything related to upload.

as soon as we migrate over to webdav in the browser this will be solved

@DeepDiver1975 DeepDiver1975 added this to the 8.1-next milestone Jan 29, 2015
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 4, 2015

Closing as duplicate then: #12353

@PVince81 PVince81 closed this as completed Feb 4, 2015
@MorrisJobke MorrisJobke removed this from the 8.1-next milestone Feb 5, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants