-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use part files for web UI upload #13755
Labels
Comments
I forgot to mention that the sync client will show an error when downloading that incomplete file. The next sync run will redownload it and all is fine in the end. |
as soon as we migrate over to webdav in the browser this will be solved |
Closing as duplicate then: #12353 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to reproduce
Expected result
No encryption error in log
Actual result
If you're (un-)luck, it might happen that the sync client sees a file while it is still being uploaded/encrypted, which results in the following:
One solution for this would be to make files that are uploaded through the Web UI also become a part file at first, until all file operations, proxies, etc are finished (for encryption). Then at the end, rename the file to the final file.
Versions
OC 8 git master, possibly happening in any version
In general I think we should start using part files for everything related to upload.
@schiesbn @DeepDiver1975 @icewind1991
The text was updated successfully, but these errors were encountered: