Don't mention the oC version number when upgrading apps

[oparoz]

Env

Oc 8.0

Steps to reproduce

1. Go to app manager
2. Enable an app which doesn't make any modification to the database
3. Go to Files

Expected result

Nothing should happen or if you have to ask the user to upgrade for some reason, then make it clear that this is about an app.

Actual result

The user is presented with a page telling him that his ownCloud version x.y should be upgraded to version x.y, the exact same version. It is confusing.

[ghost]

Probably a dup of: #14977

[oparoz]

Yep, thanks for finding it for me. I only looked for manager related issues...

[ghost]

@oparoz
But just noticed that it was suggested to create a new issue about this at #14977 (comment)

[oparoz]

@RealRancor - Thanks!

[PVince81]

This should be an easy fix.
The code that populates the update page template should check if needsUpdate() is true because of version difference of core or apps.
See the two blocks here https://github.com/owncloud/core/blob/master/lib/private/util.php#L1435

[oparoz]

Yes, that's the code which mixes everything together:

core/lib/base.php

Line 345 in 1769de0

public static function checkUpgrade($showTemplate = true) {

using this template
https://github.com/owncloud/core/blob/1769de0a6d6fcdfe2bb17d5dea42693055ed8a83/core/templates/update.admin.php

[PVince81]

This update step is not triggered by DB updates directly, it's whenever the version specified in the code for an app differs from the version we have in the database. The update step would not only run DB upgrades, if any, but also run the app's "update.php".

Now one possibility would be to try and make this more intelligent and be able to detect in advance whether DB updates are required, and whether the app provides a "appinfo/update.php" file. If none apply, then simply increase the version in the DB.
Detecting that no DB changes are required at this time would need to diff the DB schemas.

For now in 8.2 let's just fix the UI to tell that it's about updating apps instead of core.

[oparoz]

For now in 8.2 let's just fix the UI to tell that it's about updating apps instead of core.

Agreed. That's the confusing part for user.

[PVince81]

PR is here: #17434

[PVince81]

CC @jospoortvliet if you want to add this to the dev update