Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between list and gallery views for link-shared folders #16386

Closed
nclm opened this issue May 17, 2015 · 12 comments
Closed

Differences between list and gallery views for link-shared folders #16386

nclm opened this issue May 17, 2015 · 12 comments
Labels

Comments

@nclm
Copy link

nclm commented May 17, 2015

When sharing a folder from a link, the web view has two display modes: list and gallery (I believe there’s no tip about their actual names). Here’s how the pages top looks like in each option:

List view
List view

Gallery view
Gallery view

It’s not really consistent.

The list has this that the gallery doesn’t have:

  • Add button
  • Download button
  • Upload button (optional)

The gallery has this that the list doesn’t have:

  • Name of the shared folder
  • Name of the sharing person

I think it’s quite confusing, and having the same header for both would be better.

Here’s a very crude mock-up:

Mock-up
Mock-up

It has everything from both, plus:

  • Upload and Download buttons close to each other. It would also allow the Upload button to get a label when the screen is large enough, as the Download button currently does.
  • A switch UI element instead of an action button, so the user gets more easily that they can switch between two display modes.
@oparoz
Copy link
Contributor

oparoz commented May 17, 2015

The next Gallery already has the download and home button (demo), but I agree that some uniformity would be welcome.
Having the view switcher could be interesting if we add more views, like the document view for the current folder, but I don't think the documents app supports that.

@jancborchardt and his team would need to come up with a design to apply to all apps.

@jancborchardt
Copy link
Member

The design to be applied should be the one used in the Files app. That is:

  • header with buttons for »Add to your ownCloud« and »Download«
  • »Upload« button as last item in breadcrumbs

Can you apply that for the Gallery+ app @oparoz?

I do like the view switcher which shows both views and makes clear which is the currently selected state. Otherwise it might not be clear what it is.

@jancborchardt
Copy link
Member

cc @owncloud/designers as well

@oparoz
Copy link
Contributor

oparoz commented May 18, 2015

@jancborchardt - I think the "shared by X" is missing from the Files app. It's very useful to get a reminder of who's sent you the files.

@jancborchardt
Copy link
Member

@oparoz we deliberately cut this because it leaks the user name which is done nowhere else. We wanted to remove it in the Gallery app a long time ago also but the pull request never got through …

@oparoz
Copy link
Contributor

oparoz commented May 18, 2015

OK

@jancborchardt
Copy link
Member

Referencing the pull requests where we worked on this: owncloud/gallery#33 and owncloud/gallery#121

They are obsolete because basically it is fixed in Gallery+. @oparoz if the header in Gallery+ looks different from what I described above it would be cool to change it accordingly. :)

@oparoz
Copy link
Contributor

oparoz commented May 18, 2015

@jancborchardt - I've created the missing tickets in the tracker and that will be taken care of eventually, but in any case, before it becomes the official app.

@nclm
Copy link
Author

nclm commented May 18, 2015

Thanks for the answers!

Additionally, I think the name of the shared folder is really quite useful, and is more relevant than a home icon; it does not appear in the current list view, nor in the next gallery view. It’s a sort of page title, to know what is this folder being shared.

@jancborchardt
Copy link
Member

@oparoz great! Can you link them here so we can close this?

@nclm good point actually. Can you open this as a new separate issue? You are very welcome in our IRC channel #owncloud-design as well :)

@oparoz
Copy link
Contributor

oparoz commented May 19, 2015

@jancborchardt
Copy link
Member

Closing this in favor of these linked issues then. Thank you for the suggestions @nclm – please give your input in these individual issues then. :)

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants