Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of 'invisible' link shares #22295

Closed
rullzer opened this issue Feb 10, 2016 · 4 comments · Fixed by #22317
Closed

Possibility of 'invisible' link shares #22295

rullzer opened this issue Feb 10, 2016 · 4 comments · Fixed by #22317

Comments

@rullzer
Copy link
Contributor

rullzer commented Feb 10, 2016

Discovered in #22285

Since we have no way to display multiple link shares in the WebUI and we have the flat shares. There is the possibility of 'invisible' link shares.

Example:

  1. user1 shares foo with group2
  2. user2 (in group2) shares foo by link
  3. user1 unshares from group2

In the webUI user1 won't see that his file is actually still shared by link.

@rullzer rullzer self-assigned this Feb 10, 2016
@rullzer rullzer added this to the 9.0-current milestone Feb 10, 2016
@rullzer
Copy link
Contributor Author

rullzer commented Feb 10, 2016

I have a solution in mind. It won't scale if all 10K members of group2 share a file by link. But in the more likely scenario that there are only a few. All should work out.

@rullzer
Copy link
Contributor Author

rullzer commented Feb 10, 2016

Ok thinking more about this and I propose the following.

Since we still have the same database layout we can make link shares hierachcical. So:

  1. user1 shares foo with user2
  2. user2 shares foo by link

Now the link will have the share created in 1 as parent. Then when the parent is deleted we delete the share as well.

All the logic for this is still there as I did not have time to clean it up yet. (and deleting children does not hurt when there are no children).

@schiesbn lets discuss this tomorrow.

@PVince81 FYI

@schiessle
Copy link
Contributor

discussed ith with @rullzer on IRC and I agree with this approach.

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants