-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility of 'invisible' link shares #22295
Comments
I have a solution in mind. It won't scale if all 10K members of group2 share a file by link. But in the more likely scenario that there are only a few. All should work out. |
Ok thinking more about this and I propose the following. Since we still have the same database layout we can make link shares hierachcical. So:
Now the link will have the share created in 1 as parent. Then when the parent is deleted we delete the share as well. All the logic for this is still there as I did not have time to clean it up yet. (and deleting children does not hurt when there are no children). @schiesbn lets discuss this tomorrow. @PVince81 FYI |
discussed ith with @rullzer on IRC and I agree with this approach. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Discovered in #22285
Since we have no way to display multiple link shares in the WebUI and we have the flat shares. There is the possibility of 'invisible' link shares.
Example:
In the webUI user1 won't see that his file is actually still shared by link.
The text was updated successfully, but these errors were encountered: