-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for string ids (file ids, etc) #22330
Comments
@DeepDiver1975 was there any update on this discussion ? Moving to 9.2 |
@DeepDiver1975 @butonic moving to backlog for now, not sure where we are with the discussion about string ids but this is still a huge task with big potential for regressions. |
will give us headaches with functions like Cache::get() that allow int and string. Personally, I would be happy to get rid of them. If we use strings we need to add the storage to the primary key, because with strings we no longer have an autoincrement column that we can use to spit out the next fileid. Instead we have to move that logic to the storage. a fallback might be a uuid ... but maybe there are better alternatives. |
I would stay with string. Although one could have "Id" as string but "fileid" as numeric also in future.
… On 9. May 2017, at 10:40, ckamm ***@***.***> wrote:
@PVince81 @butonic The desktop client will start querying and storing oc:fileid (for local links) - shall we consider this an integer or a string, to be safe for the future?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Follow up of #20401 and #20394 regarding string id discussion
@DeepDiver1975 @icewind1991 @karlitschek
The text was updated successfully, but these errors were encountered: