Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for string ids (file ids, etc) #22330

Closed
PVince81 opened this issue Feb 11, 2016 · 5 comments
Closed

Support for string ids (file ids, etc) #22330

PVince81 opened this issue Feb 11, 2016 · 5 comments

Comments

@PVince81
Copy link
Contributor

PVince81 commented Feb 11, 2016

Follow up of #20401 and #20394 regarding string id discussion

@DeepDiver1975 @icewind1991 @karlitschek

@PVince81
Copy link
Contributor Author

@DeepDiver1975 was there any update on this discussion ?

Moving to 9.2

@PVince81 PVince81 modified the milestones: 9.2-next, 9.1-current Jun 24, 2016
@PVince81
Copy link
Contributor Author

PVince81 commented Dec 8, 2016

@DeepDiver1975 @butonic moving to backlog for now, not sure where we are with the discussion about string ids but this is still a huge task with big potential for regressions.

@butonic
Copy link
Member

butonic commented Apr 24, 2017

will give us headaches with functions like Cache::get() that allow int and string. Personally, I would be happy to get rid of them.

If we use strings we need to add the storage to the primary key, because with strings we no longer have an autoincrement column that we can use to spit out the next fileid. Instead we have to move that logic to the storage. a fallback might be a uuid ... but maybe there are better alternatives.

@ckamm
Copy link

ckamm commented May 9, 2017

@PVince81 @butonic The desktop client will start querying and storing oc:fileid (for local links) - shall we consider this an integer or a string, to be safe for the future?

@guruz
Copy link
Contributor

guruz commented May 9, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants