Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White background in favicon #22981

Closed
v1r0x opened this issue Mar 9, 2016 · 14 comments
Closed

White background in favicon #22981

v1r0x opened this issue Mar 9, 2016 · 14 comments

Comments

@v1r0x
Copy link
Contributor

v1r0x commented Mar 9, 2016

Steps to reproduce

  1. Open any app without a specific favicon

Expected behaviour

  1. Transparent background in the favicon expected

Actual behaviour

  1. White background at the corners of the favicon actual

Server configuration

Operating system: Debian Jessie

Web server: nginx 1.6.2

Database: MySQL

PHP version: 5.6

ownCloud version: (see ownCloud admin page) 9.0

Updated from an older ownCloud or fresh install: Updated

Where did you install ownCloud from: package manager (apt-get)

Signing status (ownCloud 9.0 and above):

@v1r0x
Copy link
Contributor Author

v1r0x commented Mar 9, 2016

cc @owncloud/designers

@MorrisJobke
Copy link
Contributor

I guess this is because of the move to the ICO for IE compatibility.

@MorrisJobke
Copy link
Contributor

ref #18039

@MorrisJobke
Copy link
Contributor

I think we could rework the whole favicon stuff for 9.1 because IE up to 10 isn't supported anymore in 9.1 #15567 (comment)

@jancborchardt
Copy link
Member

So, we could drop .ico again?

@MorrisJobke
Copy link
Contributor

So, we could drop .ico again?

Yes.

@v1r0x
Copy link
Contributor Author

v1r0x commented Mar 9, 2016

Recreate the .ico with transparent background should be enough. At least for 9.0.x and 8.2.x. The one in my screenshot is created from the png. I used a random ico generator on the internet. Didn't know if there is a better method to create it.

@LennartRoeder
Copy link

favicon_focused tab focused
favicon_not_focused tab not focused
I have the same issue since OC9 in Chromium under Linux and Chrome in OSX. It is just visable, when the tab is not focused though.

@jancborchardt
Copy link
Member

@MorrisJobke as far as I know you introduced the .ico support – can you remove it again?

@jancborchardt jancborchardt modified the milestones: 9.1-current, backlog Apr 8, 2016
@LennartRoeder
Copy link

With OwnCloud 9.1it looks much better. If you look for it, you can see it, but it is barely noticeable.

@PVince81 PVince81 modified the milestones: 9.1-current, 9.1.1-next-maintenance Jun 30, 2016
@MorrisJobke MorrisJobke removed their assignment Jul 27, 2016
@PVince81 PVince81 modified the milestones: 9.1.2, 9.1.1 Sep 21, 2016
@PVince81 PVince81 modified the milestones: 9.1.3, 9.1.2 Oct 20, 2016
@PVince81 PVince81 modified the milestones: 9.2, 9.1.3 Nov 30, 2016
@PVince81 PVince81 modified the milestones: 10.0, backlog Dec 8, 2016
@PVince81
Copy link
Contributor

PVince81 commented Dec 8, 2016

@felixheidecke

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@PVince81
Copy link
Contributor

looks fine to me with 10.0.5 RC3.

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants