Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store ownCloud's fileid in extended attributes #23392

Closed
PVince81 opened this issue Mar 18, 2016 · 10 comments
Closed

Store ownCloud's fileid in extended attributes #23392

PVince81 opened this issue Mar 18, 2016 · 10 comments

Comments

@PVince81
Copy link
Contributor

PVince81 commented Mar 18, 2016

If the underlying file system, local or external, supports extended attributes, how about storing the ownCloud fileid there ?

This would make it possible to:

@DeepDiver1975 @MorrisJobke @icewind1991 @Xenopathic

@PVince81
Copy link
Contributor Author

also @karlitschek @rullzer @butonic

@PVince81
Copy link
Contributor Author

I remember chatting with @schiesbn about this and he pointed out, what happens if two files report the same "fileid" from extended attributes. Not sure if that could ever happen, unless someone duplicated the file locally and the duplicate contains the same extended attrs.

@PVince81 PVince81 added this to the backlog milestone Mar 18, 2016
@karlitschek
Copy link
Contributor

yes. would be good if supported by the storage

@RobinMcCorkell
Copy link
Member

We can in fact generalize the entire thing, and store all information that is currently stored in the filecache in extended attributes. Then we offload the heavy lifting from the DB layer to the filesystem layer, which may be more performant in certain circumstances.

@butonic
Copy link
Member

butonic commented Mar 19, 2016

I feel that we come across fs specific solutions for different problems. As @karlitschek already mentioned this won't work on all fs. Nevertheless, It does solve some problems. So I am for it.

@PVince81
Copy link
Contributor Author

The Arch Wiki says that extended attributes are not copied by default with cp or rsync: https://wiki.archlinux.org/index.php/File_permissions_and_attributes#User_extended_attributes

So a situation where a duplicate fileid is found is less likely to happen. Still, need to decide what to do when found twice.

@PVince81
Copy link
Contributor Author

Ah! It seems that @icewind1991 already had a POC for this: #14546

@ghost
Copy link

ghost commented Mar 21, 2016

adding to the 9.1 discussion pile

@ghost ghost modified the milestones: 9.1-current, backlog Mar 28, 2016
@PVince81 PVince81 modified the milestones: 9.1-current, 9.2-next Jun 14, 2016
@PVince81
Copy link
Contributor Author

PVince81 commented Dec 6, 2016

@jvillafanez some food for thought, in case you haven't thought of ext attributes before

@PVince81
Copy link
Contributor Author

PVince81 commented Dec 8, 2016

moving to backlog for now

@PVince81 PVince81 modified the milestones: backlog, 10.0 Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants