-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store ownCloud's fileid in extended attributes #23392
Comments
also @karlitschek @rullzer @butonic |
I remember chatting with @schiesbn about this and he pointed out, what happens if two files report the same "fileid" from extended attributes. Not sure if that could ever happen, unless someone duplicated the file locally and the duplicate contains the same extended attrs. |
yes. would be good if supported by the storage |
We can in fact generalize the entire thing, and store all information that is currently stored in the filecache in extended attributes. Then we offload the heavy lifting from the DB layer to the filesystem layer, which may be more performant in certain circumstances. |
I feel that we come across fs specific solutions for different problems. As @karlitschek already mentioned this won't work on all fs. Nevertheless, It does solve some problems. So I am for it. |
The Arch Wiki says that extended attributes are not copied by default with cp or rsync: https://wiki.archlinux.org/index.php/File_permissions_and_attributes#User_extended_attributes So a situation where a duplicate fileid is found is less likely to happen. Still, need to decide what to do when found twice. |
Ah! It seems that @icewind1991 already had a POC for this: #14546 |
adding to the 9.1 discussion pile |
@jvillafanez some food for thought, in case you haven't thought of ext attributes before |
moving to backlog for now |
If the underlying file system, local or external, supports extended attributes, how about storing the ownCloud fileid there ?
This would make it possible to:
@DeepDiver1975 @MorrisJobke @icewind1991 @Xenopathic
The text was updated successfully, but these errors were encountered: