Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose easier job interface in public namespace #24611

Closed
MorrisJobke opened this issue May 13, 2016 · 4 comments
Closed

Expose easier job interface in public namespace #24611

MorrisJobke opened this issue May 13, 2016 · 4 comments

Comments

@MorrisJobke
Copy link
Contributor

This was already discussed for the more specific stuff (TimedJob for example) in #18756

@BernhardPosselt came up with this again and I also got hit by this:

20:14 <BernhardPosselt> apart from that OCP\BackgroundJob is also deprecated
20:15 <BernhardPosselt> is this the interface that i need to implement? https://github.com/owncloud/core/blob/master/lib/public/BackgroundJob/IJob.php
20:15 <BernhardPosselt> why do i need to implement all those getters and setters?
20:15 <BernhardPosselt> all other implementations are private
20:16 <BernhardPosselt> the job api is just broken

Maybe we want to expose a smaller interface that could then use the abstract class Job - https://github.com/owncloud/core/blob/6b5db081a55b9a7675e30a9c43950f412420bcd7/lib/private/BackgroundJob/Job.php

@PVince81 @icewind1991 @DeepDiver1975 What is the plan here?

@MorrisJobke
Copy link
Contributor Author

Maybe also @nickvergessen

@BernhardPosselt
Copy link
Contributor

Ah right, thought I added him

@MorrisJobke
Copy link
Contributor Author

Kill this as duplicate of #24609

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants