5.0.0 Sharing: display error for multiple shared folders

[mokkin]

I share some folders to two different groups. One with read-only permissions, one with write permissions too. If a user who is in both groups opens the "Shared" directory he can see the shared folders twice [with a "(2)"]

OC 5.0.0
Ubuntu 12.04 x64
PHP 5.3.10
Apache2.2.22

Firefox 19

[BernhardPosselt]

@MTGap

[MTGap]

Seems I missed a case of duplicate shares. Since it isn't critical this probably won't be fixed until 6.

[halfgaar]

In my opinion, it's more critical than that. We're setting up an owncloud server with shared repository for files, and for some users, folders don't appear as 'folder', but 'folder (2)'.

[MTGap]

@halfgaar That doesn't sound like the same thing. If the file name folder already exists for that user, it will automatically change the name to 'file (#)'. Is it doing this without the name 'folder' already existing?

[halfgaar]

No, the folder doesn't exist without the "(2)".

This user also has double entries in the web GUI. I does kind of seem related, but I can't be sure of course.

[halfgaar]

It looks like we are getting crashes from this. This user, who had the double entries, was the only one who experienced this crash (in owncloud_rmdir) (Mirall version 1.2.1):

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 5136.0x1268]
0x769f43f9 in strlen () from C:\windows\syswow64\msvcrt.dll
(gdb) backtrace
#0  0x769f43f9 in strlen () from C:\windows\syswow64\msvcrt.dll
#1  0x61cc923b in ?? () from C:\Program Files (x86)\ownCloud\libneon-27.dll
#2  0x61cc1f39 in ?? () from C:\Program Files (x86)\ownCloud\libneon-27.dll
#3  0x61cc6839 in ?? () from C:\Program Files (x86)\ownCloud\libneon-27.dll
#4  0x6cb83d29 in owncloud_rmdir (uri=0x4f5bf28 "C:\\Users\\john\\OwncloudShared/FOLDERNAME/p/SURNAME, GIVENNAME/5. Algemene informatie inhoudelijk") at /var/lib/jenkins/jobs/csync-win32-dav/workspace/mo
#5  0x6f94afe5 in _csync_remove_dir (ctx=ctx@entry=0x2f06528,st=st@entry=0x2fe16d8) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/csync_propagate.c:1082
#6  0x6f94d9cb in _csync_propagation_dir_visitor (obj=0x2fe16d8,data=data@entry=0x2f06528) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/csync_propagate.c:1441
#7  0x6f95293d in _rbtree_subtree_walk (visitor=0x6f94d9a0 <_csync_propagation_dir_visitor>, data=0x2f06528, node=0x2fe1500) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/std/c_rbtree.c:152
#8  _rbtree_subtree_walk ( visitor=0x6f94d9a0 <_csync_propagation_dir_visitor>, data=0x2f06528, node=<optimized out>) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/std/c_rbtree.c:156
#9  _rbtree_subtree_walk (node=0x2fbdf88, data=0x2f06528, visitor=0x6f94d9a0 <_csync_propagation_dir_visitor>) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/std/c_rbtree.c:156
#10 0x6f952770 in _rbtree_subtree_walk ( visitor=0x6f94d9a0 <_csync_propagation_dir_visitor>, data=0x2f06528, node=0x2e2c828) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/std/c_rbtree.c:156
#11 _rbtree_subtree_walk ( visitor=0x6f94d9a0 <_csync_propagation_dir_visitor>, data=0x2f06528, node=0x2f8a640) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/std/c_rbtree.c:148
#12 _rbtree_subtree_walk ( visitor=0x6f94d9a0 <_csync_propagation_dir_visitor>, data=0x2f06528, node=0x2f4ea58) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/std/c_rbtree.c:148
#13 _rbtree_subtree_walk (node=0x2f6b408, data=0x2f06528, visitor=0x6f94d9a0 <_csync_propagation_dir_visitor>) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/std/c_rbtree.c:148
#14 0x6f95309d in _rbtree_subtree_walk ( visitor=0x6f94d9a0 <_csync_propagation_dir_visitor>, data=0x2f06528, node=0x2f66978) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/std/c_rbtree.c:156
#15 c_rbtree_walk (tree=tree@entry=0x2f4bae0, data=data@entry=0x2f06528, visitor=visitor@entry=0x6f94d9a0 <_csync_propagation_dir_visitor>) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/std/c_rb
#16 0x6f94fa8c in csync_propagate_files (ctx=ctx@entry=0x2f06528) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/csync_propagate.c:1479
#17 0x6f942294 in csync_propagate (ctx=0x2f06528) at /var/lib/jenkins/jobs/csync-win32-dav/workspace/src/csync.c:493
#18 0x6ad746d9 in _fu328___ZN7QString11shared_nullE () from C:\Program Files (x86)\ownCloud\libowncloudsync.dll
#19 0x02f06528 in ?? ()
#20 0x6ad8dfdc in Mirall::CSyncThread::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) [clone .part.1] () from C:\Program Files (x86)\ownCloud\libowncloudsync.dll
#21 0x001005e0 in ?? ()
#22 0x00000083 in ?? ()
#23 0x00000000 in ?? ()
(gdb)

It happened after starting owncloud and waiting for it to sync. It took about 1000 seconds before it finally would sync, and then it crashed. This was very repeatable behavior.

We couldn't leave this user's Owncloud non-functional, so I removed his sync folders and Owncloud data dir and upgraded to Mirall 1.2.4 (and lost the ability to test the crash). It works now. Time will tell if this won't happen again, though.

[jancborchardt]

Or wait, actually let me reopen. Now that we’re past ownCloud 5 release, what’s the plan on this @MTGap?

[jancborchardt]

@halfgaar @mokkin I assume this is fixed in ownCloud 6, so I’m closing this. Please let me know if it still occurs for you and I’ll reopen. :)

[rribeiro]

Hello.

I'm using 6.03 and having the same problem. It's wont fixed on 6?

[jancborchardt]

@schiesbn @PVince81 can you look into this?

[PVince81]

How about 6.0.4 ?

[rribeiro]

PVince81,

I dont read about update this bug on 6.0.4. I'm using 6.0.3 now.

Do u think that upgrade will solve?

Thanks all for attention.

[PVince81]

This ticket has been used for various different old issues and I'd like to keep it closed for now.

@rribeiro please raise a separate ticket using the issue template: https://raw.github.com/owncloud/core/master/issue_template.md

If the issue you were referring to was that the recipient sees the file/folder twice then this is expected, not a bug. There is currently no way to fix this without doing major changes, especially in a stable release like OC 6. So for now this is by design.