Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared label in shared subfolder doesn't appear until opening sidebar. #25302

Closed
SergioBertolinSG opened this issue Jun 29, 2016 · 14 comments
Closed

Comments

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Jun 29, 2016

Steps to reproduce:

Having three users, user1, user2 and user3 do:

  1. As user1 create a folder called "test".
  2. As user1 create a folder called "FOLDER" inside "test"
  3. As user1 upload a file called "textfile.txt" to "/test/FOLDER"
  4. As user1 share "/test/FOLDER" with user2.
  5. As user2 share "/FOLDER/textfile.txt" with user3.
  6. As user1, go to files view, enter "/test/FOLDER" open sidebar and go to sharing tab.

Expected behaviour:

Shared label appears on every file which has shares.

Actual behaviour

Shared label appears only after opening sidebar and going to sharing tab.

screen shot 2016-06-29 at 18 22 42

### Server configuration

Operating system:
Ubuntu 14.04

Web server:
Apache

Database:
MySQL

PHP version:
5.5.9

ownCloud version: (see ownCloud admin page)
Current master on serverA and serverB
{"installed":true,"maintenance":false,"version":"9.1.0.9","versionstring":"9.1.0 beta 2","edition":"Enterprise"}

Updated from an older ownCloud or fresh install:
Fresh

The content of config/config.php:


Are you using external storage, if yes which one: local/smb/sftp/...
No

Are you using encryption:
No

Logs



Addressbooks were exchanged correctly before the tests.

Client configuration

Chrome, Firefox.

@SergioBertolinSG
Copy link
Contributor Author

cc @rullzer

@PVince81
Copy link
Contributor

Hmm, I see even another problem: at step 4 the share indicator also doesn't appear for user1 until I reload the page.

@PVince81
Copy link
Contributor

@SergioBertolinSG ok, I managed to reproduce your issue.

It looks like <oc:share-types /> is empty, so it means the Share API call we're doing to compute it doesn't properly take flat reshares into account. Or the call needs to be adjusted/extended if it was by design.

@PVince81
Copy link
Contributor

Setting to medium. It's not too bad but still an annoyance.

@PVince81 PVince81 added this to the 9.1-current milestone Jun 30, 2016
@SergioBertolinSG
Copy link
Contributor Author

Please have in mind that mobile clients (perhaps desktop too) cannot detect that those files are shared also.

@PVince81
Copy link
Contributor

Yes, this is the same issue that the Webdav attribute doesn't have the correct value.
Unless the mobile client uses the OCS Share API instead of that, in which case something else might be wrong.

@SergioBertolinSG
Copy link
Contributor Author

SergioBertolinSG commented Jun 30, 2016

Yes AFAIK they are using the share API. cc @nasli

@PVince81 PVince81 modified the milestones: 9.1-current, 9.1.1-next-maintenance Jun 30, 2016
@nasli
Copy link

nasli commented Jul 1, 2016

We use ocs/v1.php/apps/files_sharing/api/v1/shares

@SergioBertolinSG
Copy link
Contributor Author

SergioBertolinSG commented Aug 17, 2016

I see this with current master (9.2.0.1) just sharing a folder. Shared label doesn't appear. Perhaps not related with this issue, opening the sidebar doesn't help. It requires a reload.

@PVince81
Copy link
Contributor

@SergioBertolinSG the issue you are seeing is #25311

@SergioBertolinSG
Copy link
Contributor Author

Yes, it is that one.

@PVince81
Copy link
Contributor

That linked one is a Javascript issue, not related at all to the APIs

@PVince81 PVince81 modified the milestones: 9.1.2, 9.1.1 Sep 21, 2016
@PVince81 PVince81 modified the milestones: 9.1.3, 9.1.2 Oct 20, 2016
@PVince81 PVince81 modified the milestones: 9.2, 9.1.3 Nov 30, 2016
@PVince81 PVince81 self-assigned this Dec 8, 2016
@PVince81
Copy link
Contributor

closing as duplicate, #25311 is fixed in 10.0.0

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants