getetag property value in WebDAV response lacks quotes

[filipnavara]

The getetag WebDAV incorrectly contains unquoted property value (<d:getetag>e90b16c7e76844f18c9eba44af5cca1d</d:getetag>) when it should contain the exact same value as reported in the ETag header (ie. <d:getetag>"e90b16c7e76844f18c9eba44af5cca1d"</d:getetag>). This causes eM Client to treat the items as always modified since it compared the value returned by GET request to the one returned by the PROPFIND request.

http://www.webdav.org/specs/rfc4918.html#PROPERTY_getetag

[karlitschek]

Good catch. Just out of curiosity: What is you plan regarding eM Client and ownCloud?

[filipnavara]

We do not have any plans at the moment. I'm one of eM Client developers and we have several users who are interested in using it as a client against their ownCloud server(s).

[dragotin]

Please let me know when this is fixed, might affect the desktop client.

[evert]

Hi!

I just heard about issues with this as well, regarding the Bynari connector for Outlook.
Would be good to fix this, I can imagine this can cause issues for other clients as well.

This can affect Web-, Cal- and CardDAV clients.

cc: @tanghus

[tanghus]

I'm not sure what to change. It seems like it's fixed for WebDAV in cdd9ffc
Should I also change e.g. https://github.com/owncloud/apps/blob/master/contacts/lib/sabre/backend.php#L156 to

'etag' => '"'.md5($i['carddata']) . '"',

[evert]

Yes, this is exactly where the problem is. Guess I could have made that more clear in the docblocks.

[evert]

Basically any etag must be surrounded by double-quotes.

[tanghus]

Okie, will fix it in Cal- and CardDAV. Thx

[evert]

Cool!

[tanghus]

Turned out CardDAV was the only place missing. @filipnavara the commit I referred to above is 5 months old. Do you still have this problem?

[filipnavara]

Actually I had the problem with CardDAV, so the latest commit fixes it.

[tanghus]

Great. Sorry it took so long. I originally thought it was a WebDAV only issue. CardDAV issues should go to the apps repo and label app:contacts