-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use oc_mounts as authoritative fstab-like list #26190
Comments
a share might not be created until a user accepts the share. |
Ref: #19153 |
I think @DeepDiver1975 proposed something similar to that at the conf. I think this was also the discussion when twitter scaled up: |
This will become even more important once we merge #25422 which moves the external storage logic to core, because. In the past only people who had files_external enabled would likely have a performance decrease because the oc_external_* config tables need to be read every time the FS is mounted. If we have a fstab-like table then the minimum required for setting up a usable FS is reading the fstab table (oc_mounts ?). And only once someone uses the API to access any of the mounts, we might need to read the external storage config or share info to resolve it. But I guess that even that could be cached somehow. |
Another advantage of this idea is that users could really move around any kinds of mounts because their origin would be tracked in |
Hey, this issue has been closed because the label (This is an automated comment from GitMate.io. |
Currently oc_mounts is populated when a user's filesystem is getting set up.
This means that when setupFS is called, it will ask all mount providers to provide mounts.
This also means that the share mount provider will have to read the shares from oc_share, every time!
How about making it work differently: the oc_mounts becomes a fstab-like list and setupFS only ever mounts what's written in there. The table must then be populated at a different time, for example whenever a share is created or an external storage added, or a user added to a group, etc. (which is likely a big challenge). Or this could be done in a background job.
@DeepDiver1975 @butonic @owncloud/filesystem
The text was updated successfully, but these errors were encountered: