Disallow old chunking on new endpoint

[PVince81]

With old chunking we mean the ugly file names like "data1.dat-chunking-3886638851-13-1".

Whenever a client sends "OC-Chunking" header, deny access to the new endpoint "remote.php/dav/files/$user".

@DeepDiver1975 as discussed

This would help reducing test cases.

[guruz]

Please only after new enough clients are in the wild e.g. for owncloud/client#5855

;)

[PVince81]

Depends... it is likely that old clients cannot work anyway due to this bug #28197. So either we invest time in fixing old chunking with new dav (that if-match thing) or block it right away.

That is, unless we find scenarios where it does work correctly still.

[mrow4a]

@PVince81 should I write a PR with what you need on the server? I will also include smashbox test verifying all these issues. I am just afraid of bunch of clients which will have errors ;d

[mrow4a]

Ok, I think forbiding new endpoint for old chunking is "must have"... it is probably better then investigating how to write a test how to play with aborded chunking and overwriting in crazy scenarious in smashbox.. will take care of it.

[PVince81]

Possible technical approaches:

1. one size fits all: write a plugin that denies any request on the new DAV endpoint if OC-Chunking is set

or

2. go through every possible code path that have "OC-Chunking" set and add a check whether we're coming from the new dav endpoint. Might require adding a flag in the plugin that the instantiator tells in which endpoint we are.

[mrow4a]

I like number 1 👍

[mrow4a]

#28263

[mrow4a]

@PVince81 close?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.