Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all link shares for share owner, even those created by recipients #29519

Closed
PVince81 opened this issue Nov 9, 2017 · 5 comments
Closed

Comments

@PVince81
Copy link
Contributor

PVince81 commented Nov 9, 2017

Steps

  1. Create three users "user1", "user2", "user3"
  2. Login as "user1"
  3. Create a folder "test"
  4. Share "test" with link, call it "my link"
  5. Share "test" with "user2"
  6. Login as "user2"
  7. Share "test" with link, call it "two link"
  8. Login as "user3"
  9. Share "test" with link, call it "three link"
  10. Login as "user1"
  11. Open share panel

Expected result

Three links displayed: my link, two link, and three link with a hint about share owner.
User2 and user3 only see own links.

Actual result

Only own link "my link" displayed.
User2 and user3 still only see own links.

Version

10.0.3

Please note that technically the information is already available through the APIs, it's just filtered out.
We could never do this in the past because there was no room in the UI for multiple links. Since 10.0 has multiple link UI, we could add this now.

@pmaier1 @felixheidecke

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 9, 2017

By the way, there is a bug that the activity app will send you an email to notify you whenever someone created a link share from your share, but you'll never see said share.

Depending whether we want this feature or not, we might need to address that bug...

@PVince81
Copy link
Contributor Author

Talked with @pmaier1 the other day and agreed that this makes sense.

We'll need to make way in the UI to display the user id / display name of whoever created that share (uid_initiator).

@PVince81
Copy link
Contributor Author

Requires #29816 to make space for the initiator name.

@PVince81
Copy link
Contributor Author

Need to coordinate with client devs as well to display the info there once the server has it too @michaelstingl

@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants