Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow single user sync of new users #31028

Closed
tomneedham opened this issue Apr 6, 2018 · 3 comments · Fixed by #31029
Closed

Allow single user sync of new users #31028

tomneedham opened this issue Apr 6, 2018 · 3 comments · Fixed by #31029
Assignees
Labels
p2-high Escalation, on top of current planning, release blocker sev3-medium
Milestone

Comments

@tomneedham
Copy link
Member

Steps to reproduce

  1. Add a new user to LDAP
  2. Run single user sync from the CLI using the username attribute

Expected behaviour

The new user is discovered, account created and synced.

Actual behaviour

The account is not found.

HEAD@ ef8e4a4
user_ldap 0.10.0

This is because core checks the backend for userExists($uid) with the value passed in from the command line argument. LDAP->userExists() is here.

This will check for cached users within this process, then look for mapped users, but no more than this. So any not yet discovered user will not be found. This method should be extended to also do a search with $backed->getUsers($uid, 1, 0). Core must then translate the uid from the input to the one returned through this method before creating an account and syncing.

cc @butonic

@tomneedham tomneedham added app:user_ldap sev3-medium p2-high Escalation, on top of current planning, release blocker labels Apr 6, 2018
@tomneedham tomneedham added this to the development milestone Apr 6, 2018
@tomneedham tomneedham self-assigned this Apr 6, 2018
@PVince81
Copy link
Contributor

PVince81 commented Apr 6, 2018

no time for "development" now, moving to "planned"

@PVince81 PVince81 modified the milestones: development, planned Apr 6, 2018
@ownclouders
Copy link
Contributor

GitMate.io thinks the contributors most likely able to help are @jvillafanez, and @PVince81.

Possibly related issues are #30485 (Introduce single user and seen users sync), #28212 (allow syncing single users, add verbose and very verbose output), #23838 (Allow disabling of a single user), #25164 (Allow user specific maintenance mode), and #18070 (Unable to create new user).

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2-high Escalation, on top of current planning, release blocker sev3-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants