Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Better naming for "App-Password" in settings/personal #31140

Closed
mmattel opened this issue Apr 16, 2018 · 5 comments
Closed

Comments

@mmattel
Copy link
Contributor

mmattel commented Apr 16, 2018

Steps to reproduce

  1. Goto settings/personal at the bottom to App-Passwords

Expected behaviour

The term App-Password has room for improvement.
Even it is a kind of password, it´s correct terminology would be token.
Because we already use password, I propose to write: App-Password (Token) instead (text change only)
Please see also #31101 (Improving token_auth_enforced description text in config.sample.php)
The location of change is in (L23 and L36):

<h2 class="app-name"><?php p($l->t('App passwords'));?></h2>

Actual behaviour

image

Server configuration

ownCloud version: (see ownCloud admin page) 10.0.7

@phil-davis @SamuAlfageme

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #8569 (Feature requests), #12530 (Feature Request), #4451 (feature request: increase user password strength), #5167 (Add "Repeat Password" field in personal settings), and #7341 ([FEATURE REQUEST] Force users to password protect shares as link).

@phil-davis
Copy link
Contributor

In the client apps, the "token" value generated here is entered in the password field on the client app. There has been some usage of "device password" - but the "devices" out in the real world are smartphones/tablets... that run an app(s) on the device, and this password/token is entered into the app that is running on the device.

After having entered a few of these today in my phones/tablets while testing, from a user POV they seem like just an annoyingly long password to type into the app.

So I am inclined to keep calling them "app passwords".

Other opinions welcome!

@mmattel
Copy link
Contributor Author

mmattel commented Apr 17, 2018

I just want to highlight, that the password as "string" is once related to the term password and once with the term "token". Both are valid. Some apps will have the one, some the other term. I want to "link" these terms for all parties out here reducing confusion.
BTW, we have in config.sampe.php (see refrenced issue) also the term token...
(And the php script for this is named tokens.php)

@mmattel
Copy link
Contributor Author

mmattel commented May 30, 2018

Closing, PR got merged

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants