Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make easier the occ files:scan --repair #31166

Closed
cdamken opened this issue Apr 17, 2018 · 8 comments
Closed

make easier the occ files:scan --repair #31166

cdamken opened this issue Apr 17, 2018 · 8 comments

Comments

@cdamken
Copy link
Contributor

cdamken commented Apr 17, 2018

Related to #31165

The storages do not represent which users are the one to have to be repaired.

it will be much easier for the administrators:

occ files:scan --repair [Storage Number]

because not all the storage from one user have to be repaired.

or at least in the output from #31165 could say which users are the one who has to be repaired?

some admins do not know where to search which is the owner of each storage.

@tomneedham @butonic @PVince81

@cdamken cdamken self-assigned this Apr 17, 2018
@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #31077 (occ files:scan error), #19115 (occ files:scan's memory consumption grows with amount of files scanned), #26516 (occ file scan on some big file failed), #4206 (filecache scans files forever), and #23451 (occ files:scan aborted when lacking permissions).

@mmattel
Copy link
Contributor

mmattel commented Apr 20, 2018

What about splitting:
occ files:scan --repair --check
which gives you the storage number(s) needing a repair, then
occ files:scan --repair [Storage Number, Storage Number, ...]

@mmattel
Copy link
Contributor

mmattel commented May 1, 2018

I vote for this. During upgrading to 10.0.8 I got the following message:

  • Repair warning: The file cache contains entries where the parent id does not point to any existing entry for the following storage numeric ids: 11
  • Repair warning: Please run occ files:scan --all --repair to repair all affected storages

Running the repair command for all users (as you do not know which one is affected) can take a very long time especially on many users and if there are storage types with a very slow connection...
(The command on my system is now running for hours beeing in singleuser --on = no user access possible)

@PVince81
Copy link
Contributor

I suggest adding an option --storage-numeric-id for that and apply it to anything related to scanning, repair or not. (we already have --path)

@PVince81 PVince81 added this to the backlog milestone May 22, 2018
@PVince81
Copy link
Contributor

Note that long term we except that such repairing is not necessary any more. There were some older OC versions that caused file cache corruption when moving folders cross-storage and the issue is fixed, so we expect that such corruption will never occur again. So once everyone have fixed their storages the command should not be needed any more.

@mmattel
Copy link
Contributor

mmattel commented May 22, 2018

But dont we need then also an option to tell which storage id to be checked?

@PVince81
Copy link
Contributor

yes, the option will be useful anyway

@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants