Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Hide sections that have no panels to display #31246

Closed
pmaier1 opened this issue Apr 23, 2018 · 9 comments
Closed

Settings: Hide sections that have no panels to display #31246

pmaier1 opened this issue Apr 23, 2018 · 9 comments

Comments

@pmaier1
Copy link
Contributor

pmaier1 commented Apr 23, 2018

Users are confused when they see sections in the settings that have no panels (because apps that would insert panels are disabled). Anyway, it would be a lot more elegant to hide such sections instead of displaying "Error: No panels for this section.".

hide_unused_settings

I know that @tomneedham started with this when reworking the settings page for ownCloud 10.

@PVince81

@pmaier1 pmaier1 added enhancement p3-medium Normal priority labels Apr 23, 2018
@pmaier1 pmaier1 added this to the development milestone Apr 23, 2018
@phil-davis
Copy link
Contributor

Yes, at least for the first cut at it, remove the "Error" in big letters :)

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #1329 (sharing folder: no "create" setting displayed initially), #9098 (Display remote shares in "Shared with you" section), #27518 (Avoid the error when there're no panels to show under one section on settings ), #965 (No settings dialogue for Pictures section), and #30394 (Display original share owner in share panel).

@pmaier1
Copy link
Contributor Author

pmaier1 commented Apr 23, 2018

Yes, at least for the first cut at it, remove the "Error" in big letters :)

Yes, a better message to not confuse users with "errors" would be a first step in the right direction. Depending on effort for the proper solution this would be the quick fix.

In general I would really favor the approach to hide sections that have no content. Just checked quickly: For "Additional" admin/user sections this applies, too, and potentially to others as well.

@SamuAlfageme
Copy link

@pmaier1 dupe of #27518 - close one of 'em

@PVince81
Copy link
Contributor

there is some tricky API issue here as we only know at render time, might need a clever hack.

estimate: 1-3md depending on how hacky/clean it is. hopefully not breaking the panels API

cc @tomneedham

@PVince81 PVince81 modified the milestones: development, triage Apr 24, 2018
@tomneedham
Copy link
Contributor

I wanted to allow panels to respond if they are hidden or not - allowing for a more efficient code stack rather than rendering them all and generating the section list. Baby step: nicer message: 2 min job. Real fix: extend the api and implement this in all panels.

@pmaier1
Copy link
Contributor Author

pmaier1 commented Jan 17, 2020

#36775

@pmaier1 pmaier1 closed this as completed Jan 17, 2020
@youssefskhiri
Copy link

Users are confused when they see sections in the settings that have no panels (because apps that would insert panels are disabled). Anyway, it would be a lot more elegant to hide such sections instead of displaying "Error: No panels for this section.".

hide_unused_settings

I know that @tomneedham started with this when reworking the settings page for ownCloud 10.

@PVince81

Im facing this problem, I've installed owncloud on a container and I want to inegrate collabora with it
According to official documentation its in additional section which is in my case with the same error ( Error: No panels for this section. )

I would be glad if I get a solution from you :)

@iasdeoupxe
Copy link
Contributor

AFAICT what you are describing is completely irrelevant / unrelated to this issue:

IIUC this feature request was about hiding the "No panels for this section" if there is NOTHING to show, NOT about that there is something to show but is isn't showing up (what you seems to think).

Your issue sounds more like a support request for https://central.owncloud.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants