Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API acceptance tests webDav.php checkFavoritedElementsPaginated() #31725

Closed
phil-davis opened this issue Jun 12, 2018 · 7 comments
Closed

API acceptance tests webDav.php checkFavoritedElementsPaginated() #31725

phil-davis opened this issue Jun 12, 2018 · 7 comments

Comments

@phil-davis
Copy link
Contributor

has parameters offset and limit that are never used.

The test scenario Get favorited elements paginated in favorites.feature uses this. So the test scenario is not checking what you might think it checks.

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #22492 (test), #22485 (test), #31579 (test), #425 (webdav.php unauthorized), and #31403 (Expand API acceptance tests).

@phil-davis
Copy link
Contributor Author

@paurakhsharma can you put this on your list of things to look at?

@paurakhsharma
Copy link
Member

Yes, I will check it after I am done with some API sharing tests.

@phil-davis
Copy link
Contributor Author

No huge rush, but it is nice to have tests that do what it looks like they do :)

@paurakhsharma
Copy link
Member

Yes definitely :)

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants