Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

togglegroups.php ajax controller does not error if not added to group #31787

Closed
tomneedham opened this issue Jun 14, 2018 · 2 comments
Closed

Comments

@tomneedham
Copy link
Contributor

If no group supports adding to a group, then it is just assumed it was added anyway: https://github.com/owncloud/core/blob/master/lib/private/Group/Group.php#L169

This breaks the user management which has no idea if it was sucessful or not.
https://github.com/owncloud/user_management/blob/master/ajax/togglegroups.php#L79-L83

Breaks the add member command as well: https://github.com/owncloud/core/blob/master/core/Command/Group/AddMember.php#L86

@PVince81 PVince81 added this to the backlog milestone Jun 14, 2018
@ownclouders
Copy link
Contributor

GitMate.io thinks the contributors most likely able to help are @butonic, and @PVince81.

Possibly related issues are #28840 (-Error-), #26902 (error), #17420 (Adding a user to a group does not manipulate the user count), #5841 ([OC6Beta4] Add new user with group -- group menu doesn't recover), and #29082 (a Error).

@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants