Scrolling-related webUI acceptance test failures

[phil-davis]

In the last day or so, many CI jobs have had webUI test failures for:

1. scrolling down the files page and opening the file actions menu

  Scenario: scroll the file actions menu into view                                           # /home/phil/git/owncloud/core/tests/acceptance/features/webUIFiles/scrollMenuIntoView.feature:16
    When the user creates so many files/folders that they do not fit in one browser page     # WebUIFilesContext::theListOfFilesFoldersDoesNotFitInOneBrowserPage()
    Then the files action menu should be completely visible after opening it using the webUI # WebUIFilesContext::theFilesActionMenuShouldBeCompletelyVisibleAfterOpeningItUsingTheWebUI()
      Failed asserting that 870 is less than 870.
SCENARIO RESULT: (fail)

Sometimes the opened file actions menu is exactly at the bottom of the page. The test current fails for that case.

2. when opening the file actions menu, if the file is at or near the bottom of the page, then the file list scrolls so that the file actions menu can be seen. The scrolling takes time, so we need to wait enough before we click an action (delete,...). Currently there are errors like:

  Scenario: Delete files & folders one by one and check its existence after page reload # /drone/src/tests/acceptance/features/webUIFiles/deleteFilesFolders.feature:15
Error while deleting file
Error while deleting file
-------------------------
Page\FilesPageElement\FileActionsMenu::findButton xpath //a[@data-action='Delete'] could not find button 'Delete' in action Menu
-------------------------

Error while deleting file
Error while deleting file
-------------------------
element not visible
  (Session info: chrome=67.0.3396.87)
  (Driver info: chromedriver=2.40.565383 (76257d1ab79276b2d53ee976b2c3e3b9f335cde7),platform=Linux 4.4.0-127-generic x86_64)
-------------------------

Error while deleting file
-------------------------
element not visible
  (Session info: chrome=67.0.3396.87)
  (Driver info: chromedriver=2.40.565383 (76257d1ab79276b2d53ee976b2c3e3b9f335cde7),platform=Linux 4.4.0-127-generic x86_64)
-------------------------

INFORMATION: retried to delete file 'lorem.txt' 5 times
Error while deleting file
-------------------------
unknown error: Element <a href="#" class="menuitem action action-delete permanent" data-action="Delete">...</a> is not clickable at point (726, 851). Other element would receive the click: <span>...</span>
  (Session info: chrome=67.0.3396.87)
  (Driver info: chromedriver=2.40.565383 (76257d1ab79276b2d53ee976b2c3e3b9f335cde7),platform=Linux 4.4.0-127-generic x86_64)
-------------------------

Error while deleting file
-------------------------
unknown error: Element <a href="#" class="menuitem action action-delete permanent" data-action="Delete">...</a> is not clickable at point (726, 851). Other element would receive the click: <span>...</span>
  (Session info: chrome=67.0.3396.87)
  (Driver info: chromedriver=2.40.565383 (76257d1ab79276b2d53ee976b2c3e3b9f335cde7),platform=Linux 4.4.0-127-generic x86_64)
-------------------------

INFORMATION: retried to delete file 'strängé filename (duplicate #2 &).txt' 2 times
    When the user deletes the following elements using the webUI                        # WebUIFilesContext::theUserDeletesTheFollowingElementsUsingTheWebUI()
      | name                                  |
      | simple-folder                         |
      | lorem.txt                             |
      | strängé नेपाली folder                 |
      | strängé filename (duplicate #2 &).txt |
      │ INFORMATION: retried to delete file 'lorem.txt' 5 timesINFORMATION: retried to delete file 'strängé filename (duplicate #2 &).txt' 2 times
    Then the deleted elements should not be listed on the webUI                         # WebUIFilesContext::theDeletedMovedElementsShouldBeListedOnTheWebUI()
      file row of  file 'lorem.txt' in current folder is visible but should not
      Failed asserting that true is false.
    And the deleted elements should not be listed on the webUI after a page reload      # WebUIFilesContext::theDeletedMovedElementsShouldBeListedOnTheWebUIAfterPageReload()
SCENARIO RESULT: (fail)

--- Failed scenarios:

    /drone/src/tests/acceptance/features/webUIFiles/deleteFilesFolders.feature:15

We need to do better waiting for the file actions menu to really be open, scrolled into view and ready for clicking.

[phil-davis]

These issues are related to timing and the exact height of the browser window. So some combination of changes in chrome, chrome-webdriver, the docker containers and performance of the drone workers could have made these latent test issues happen more often.

[ownclouders]

GitMate.io thinks possibly related issues are #22492 (test), #31579 (test), #22485 (test), #31718 (Improve webUI autocompletion acceptance tests), and #31523 (Acceptance test refactoring and bug fixes).

[phil-davis]

PR #31791 and backport #31793

[phil-davis]

Fixed.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.