Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact match when sharing is only on UID #31831

Closed
phil-davis opened this issue Jun 19, 2018 · 6 comments
Closed

Exact match when sharing is only on UID #31831

phil-davis opened this issue Jun 19, 2018 · 6 comments

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Jun 19, 2018

Steps to reproduce

  1. Set in config.php
'user.search_min_length' => '4',
  1. Create user new with display name "Jim" and email address a@b
  2. Try to share a file, type in new - the user Jim is shown as an exact match suggestion - good
  3. Type in "Jim" or "jim" - no match is shown - not good
  4. Type in "a@b" - no match is shown - theoretically not good, in practice email addresses are never this short.

If you set:

'user.search_min_length' => '2',

and type "jim" or "a@b" in the sharing box, then it happily shows "Jim" as a match - so when such strings are greater than search_min_length, then the backend is providing matches on display name and email address.

Expected behaviour

An exact match lookup should return an exact match on display name or email address, as well as on UID.

Actual behaviour

An exact match for a short string is only returning an exact match on UID.

Server configuration

Operating system:
Ubuntu 18.04

Web server:
PHP dev server

Database:
mySQL

PHP version:
v7.2.5 (problem is no different than on PHP 7.1 etc)

ownCloud version: (see ownCloud admin page)
10.0.9RC1
10.0.8.5
(same behavior on both versions)

Updated from an older ownCloud or fresh install:
Fresh

Where did you install ownCloud from:
tarball

@phil-davis
Copy link
Contributor Author

This only becomes a problem if the sysadmin sets user.search_min_length to a "large" value and there are users on the system with shorter display name and/or email address. It becomes difficult to share with those users.

@phil-davis
Copy link
Contributor Author

See #31117 for a slightly different way this impacts occ user:list

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #765 (Sharing error), #9918 (Calendar share), #7380 (Contact sharing), #5401 (Sharing completion), and #3465 (Sharing files).

@PVince81
Copy link
Contributor

Good point. It is possible that with LDAP you can specify the LDAP search string to make it exact match whatever you want.

Like you said we should consider to also exact match display name and email. I'm not sure if this is a bug or enhancement. Tagging as bug for now.

@pmaier1

@PVince81 PVince81 added this to the backlog milestone Jun 21, 2018
@phil-davis
Copy link
Contributor Author

I'm not sure if this is a bug or enhancement

or feature ;)

@stale
Copy link

stale bot commented Sep 21, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants