[10.0.9] Disabling comments breaks files_versions

[michaelstingl]

Steps to reproduce

1. occ app:disable comments
2. Click on "Versions" tab in right panel

Expected behaviour

"Versions" tab should become active and version information should become visible.

Actual behaviour

"Versions" tab doesn't become active and I can no longer open right panel for any other file in this directory

Server configuration

Operating system:
Ubuntu 16.04

Web server:
Apache/2.4.18

Database:
MySQL

PHP version:
PHP 7.0.30

ownCloud version: (see ownCloud admin page)
ownCloud 10.0.9 (stable)

Updated from an older ownCloud or fresh install:
fresh install

Where did you install ownCloud from:
https://github.com/owncloud-docker/server

Signing status (ownCloud 9.0 and above):

No errors have been found.

The content of config/config.php:

root@4eecf4f599b3: /var/www/owncloud # occ config:list
{
    "system": {
        "datadirectory": "\/mnt\/data\/files",
        "apps_paths": [
            {
                "path": "\/var\/www\/owncloud\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/owncloud\/custom",
                "url": "\/custom",
                "writable": true
            }
        ],
        "dbtype": "mysql",
        "dbhost": "db:3306",
        "dbname": "owncloud",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "trusted_domains": [
            "localhost"
        ],
        "mysql.utf8mb4": true,
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "http:\/\/localhost\/",
        "version": "10.0.9.5",
        "logtimezone": "UTC",
        "installed": true,
        "instanceid": "ocrpe6f0gldp",
        "updatechecker": "false",
        "upgrade.disable-web": "true",
        "redis": {
            "host": "redis",
            "port": 6379
        },
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "filelocking.enabled": "true",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "maintenance": false,
        "loglevel": "2",
        "default_language": "en",
        "htaccess.RewriteBase": "\/"
    },
    "apps": {
        "backgroundjob": {
            "lastjob": "12"
        },
        "comments": {
            "enabled": "no",
            "installed_version": "0.3.0",
            "types": "logging,dav"
        },
        "configreport": {
            "enabled": "yes",
            "installed_version": "0.1.1",
            "types": "filesystem"
        },
        "core": {
            "backgroundjobs_mode": "cron",
            "installedat": "1532254065.0591",
            "lastcron": "1532255521",
            "lastupdatedat": "0",
            "oc.integritycheck.checker": "[]",
            "public_files": "files_sharing\/public.php",
            "public_webdav": "dav\/appinfo\/v1\/publicwebdav.php",
            "vendor": "owncloud"
        },
        "dav": {
            "enabled": "yes",
            "installed_version": "0.3.2",
            "types": "filesystem"
        },
        "federatedfilesharing": {
            "enabled": "yes",
            "installed_version": "0.3.1",
            "types": "filesystem"
        },
        "federation": {
            "enabled": "yes",
            "installed_version": "0.1.0",
            "types": "authentication"
        },
        "files": {
            "cronjob_scan_files": "500",
            "enabled": "yes",
            "installed_version": "1.5.1",
            "types": "filesystem"
        },
        "files_external": {
            "enabled": "yes",
            "installed_version": "0.7.1",
            "ocsid": "166048",
            "types": "filesystem"
        },
        "files_sharing": {
            "enabled": "yes",
            "installed_version": "0.10.1",
            "types": "filesystem"
        },
        "files_trashbin": {
            "enabled": "yes",
            "installed_version": "0.9.1",
            "types": "filesystem"
        },
        "files_versions": {
            "enabled": "yes",
            "installed_version": "1.3.0",
            "types": "filesystem"
        },
        "files_videoplayer": {
            "enabled": "yes",
            "installed_version": "0.9.8",
            "types": ""
        },
        "firstrunwizard": {
            "enabled": "yes",
            "installed_version": "1.1",
            "ocsid": "166055",
            "types": ""
        },
        "market": {
            "enabled": "yes",
            "installed_version": "0.2.4",
            "types": ""
        },
        "notifications": {
            "enabled": "yes",
            "installed_version": "0.3.4",
            "types": "logging"
        },
        "provisioning_api": {
            "enabled": "yes",
            "installed_version": "0.5.0",
            "types": "prevent_group_restriction"
        },
        "systemtags": {
            "enabled": "yes",
            "installed_version": "0.3.0",
            "types": "logging"
        },
        "updatenotification": {
            "enabled": "yes",
            "installed_version": "0.2.1",
            "types": ""
        }
    }
}

List of activated apps:

root@4eecf4f599b3: /var/www/owncloud # occ app:list
Enabled:
  - configreport: 0.1.1
  - dav: 0.3.2
  - federatedfilesharing: 0.3.1
  - federation: 0.1.0
  - files: 1.5.1
  - files_external: 0.7.1
  - files_sharing: 0.10.1
  - files_trashbin: 0.9.1
  - files_versions: 1.3.0
  - files_videoplayer: 0.9.8
  - firstrunwizard: 1.1
  - market: 0.2.4
  - notifications: 0.3.4
  - provisioning_api: 0.5.0
  - systemtags: 0.3.0
  - updatenotification: 0.2.1
Disabled:
  - comments
  - encryption
  - external
  - user_external
  - user_ldap

Are you using external storage, if yes which one: local/smb/sftp/...
no

Are you using encryption: yes/no
no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
no

Client configuration

Browser:
Chrom 67

Operating system:
macOs 10.13.6

Logs

Web server error log

n.a.

ownCloud log (data/owncloud.log)

n.a.

Browser log

backbone.js?v=a9e1a600d8a15933c86dcad2284676cf:1031

Uncaught TypeError: this.sync is not a function
    at child.fetch (backbone.js?v=a9e1a600d8a15933c86dcad2284676cf:1031)
    at child.nextPage (versionstabview.js?v=a9e1a600d8a15933c86dcad2284676cf:80)
    at child.setFileInfo (versionstabview.js?v=a9e1a600d8a15933c86dcad2284676cf:178)
    at child.selectTab (detailsview.js?v=a9e1a600d8a15933c86dcad2284676cf:207)
    at child._onClickTab (detailsview.js?v=a9e1a600d8a15933c86dcad2284676cf:102)
    at HTMLDivElement.dispatch (jquery.min.js?v=a9e1a600d8a15933c86dcad2284676cf:3)
    at HTMLDivElement.r.handle (jquery.min.js?v=a9e1a600d8a15933c86dcad2284676cf:3)
fetch @ backbone.js?v=a9e1a600d8a15933c86dcad2284676cf:1031
nextPage @ versionstabview.js?v=a9e1a600d8a15933c86dcad2284676cf:80
setFileInfo @ versionstabview.js?v=a9e1a600d8a15933c86dcad2284676cf:178
selectTab @ detailsview.js?v=a9e1a600d8a15933c86dcad2284676cf:207
_onClickTab @ detailsview.js?v=a9e1a600d8a15933c86dcad2284676cf:102
dispatch @ jquery.min.js?v=a9e1a600d8a15933c86dcad2284676cf:3
r.handle @ jquery.min.js?v=a9e1a600d8a15933c86dcad2284676cf:3

[ownclouders]

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #13402 (... broken), #23107 (New Install Problems (9.0.0)), #23244 (Update to 9.0.0 failed), and #28721 ([10.0.3 beta] Public links: Icons without label should have tooltip).

[PVince81]

@michaelstingl regression ? in what version did it work correctly ?

knowing the code in question it is likely that this never worked correctly

[michaelstingl]

regression ? in what version did it work correctly ?

Not sure about it – I thought I used it before, and I normally have unnecessary features/apps disabled.

[PVince81]

PR here: #32184

also thanks a lot because this indirectly might help us fix some other complicated thing over here #30088 (comment)