Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance tests should run OK not as www-data #32459

Closed
phil-davis opened this issue Aug 27, 2018 · 3 comments
Closed

Acceptance tests should run OK not as www-data #32459

phil-davis opened this issue Aug 27, 2018 · 3 comments
Assignees
Labels

Comments

@phil-davis
Copy link
Contributor

In theory, the acceptance tests are "black box". They should not need to run as the web server user name (e.g. www-data). They should be just accessing the API and webUI. When they want to do setup, run/test an occ command then they use the testing app API to do that.

We should be able to remove su-exec www-data from our run.sh acceptance test commands.

@phil-davis
Copy link
Contributor Author

phil-davis commented Aug 27, 2018

PR #32458 demonstrates the current situation. Most tests pass. Some fail (e.g. some local/external storage tests). https://drone.owncloud.com/owncloud/core/9789

Need to look into these and see what they are doing that should/could be done in a more "black box" way.

It has been looked into and is now passing.

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @individual-it.

Possibly related issues are #22485 (test), #31579 (test), #22492 (test), #30855 ([Stable10] Acceptance tests not being able to run from daily-stable10-qa tarball), and #32040 (fix acceptance tests).

@phil-davis
Copy link
Contributor Author

core and testing PRs reference above make this work in core.
Other PRs in apps have also successfully removed su-exec www-data from before run.sh
The test runner code is another step more independent from the server-under-test.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants