Rewire button to notify users for local shares to use notifications API

[PVince81]

Since recent OC versions (10.0.8 or 10.0.9), an email is already sent to recipients through the OC notifications framework. This obsoletes the need for this button.

Would be good if we could remove it at least in OC 11 as it would save a lot of refactoring work that is needed to remove the old Sharing 1.0 code. See #26608

@pmaier1

[PVince81]

I remember a discussion with @pmaier1 where it was said that we should not remove the button.

However would could maybe rewire it to send a notification through the notification framework instead of a direct email.

[VicDeo]

@PVince81 What's proposed

• add a new endpoint into files_sharing to send the notification via OCP\Notification\IManager OCA\Files_Sharing\Controllers\ShareController new controller is needed
• rewire the button to this endpoint and reword the text into 'Notify user'
  is it ok?

[PVince81]

actually this is the current controller https://github.com/owncloud/core/blob/v10.0.10/apps/files_sharing/lib/API/Share20OCS.php#L51 🙈

one day we should convert this to OCSController...

I suggest adding a method there, it needs to be a public API (OCS) so we can reuse it from Phoenix later on

[PVince81]

at first I thought just rewire the "MailNotifications" but you're right that we need to think further and moving to a controller method is the right way to go

[VicDeo]

@PVince81 one day is now :)
#33180

[VicDeo]

@PVince81 if we are removing mail notification for sharing in favor of activity emails \OC\Share\MailNotifications should die along with mail templates core/templates/mail.php and core/templates/altmail.php
\OC\Share\MailNotifications is used in core/ajax/share.php only

[PVince81]

@VicDeo the mail notification for link shares must stay. It's only the ones for local shares that would be moved to notifications, since local users can receive those.