Acceptance test OwncloudPage and waitTillPageIsLoaded

[phil-davis]

See PR #33158 and #33149 for examples and discussion.

OwncloudPage has a waitTillPageIsLoaded() method that looks for a .loading indicator to become invisible. On ordinary files pages there is no such indicator, and FilesPageBasic extends OwncloudPage and implements a waitTillPageIsLoaded() that works on files-type-pages.

Some other pages directly extend OwncloudPage and so get the "base" waitTillPageIsLoaded()

When the comments app is enabled, the comments panel happens to have a .loading indicator - so the "base" waitTillPageIsLoaded() just happens to "work" by checking that page element.

• review each page object that extends OwncloudPage and ensure that either it implements its own appropriate waitTillPageIsLoaded() or that the base one from OwncloudPage is relevant.

[phil-davis]

Try running the acceptance test suite with:

• comments app disabled PoC [PoC] Run tests without the comments app #32972 and needed code changes merged in PR Make tests work with comments app disabled #33471
• trashbin app disabled [PoC] Test with trashbin app disabled #33162 - works
• versions app disabled [PoC] Test with versions app disabled #33163 - works

and see what bad things happen.

[ownclouders]

GitMate.io thinks possibly related issues are #22485 (test), #22492 (test), #31579 (test), #32559 (acceptance tests - stop uploading when receiving an error), and #31516 (Acceptance test coding standard changes).