Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag acceptance tests that require real internet access #33639

Closed
phil-davis opened this issue Nov 23, 2018 · 2 comments · Fixed by #34293
Closed

Tag acceptance tests that require real internet access #33639

phil-davis opened this issue Nov 23, 2018 · 2 comments · Fixed by #34293

Comments

@phil-davis
Copy link
Contributor

Some acceptance tests can go out to the real internet, e.g. checking that help links on a page actual point to somewhere valid and "correct". e.g. #33635

  1. Tag those with some tag like @real-internet-required - then we can easily skip them when running against a system-under-test that is somewhat isolated from the "real internet"

and/or

  1. Think of other ways to achieve the purpose of the test.

For discussion.

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #32865 (tag acceptance test features/scenarios that require the files_sharing_app), #31579 (test), #22485 (test), #22492 (test), and #31516 (Acceptance test coding standard changes).

@phil-davis
Copy link
Contributor Author

Related test scenario has been removed. Basically it is not a great idea to rely on the live internet for tests.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants