Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing lock owner when creating lock after logging in by email address #33822

Closed
PVince81 opened this issue Dec 7, 2018 · 6 comments · Fixed by #33823
Closed

Missing lock owner when creating lock after logging in by email address #33822

PVince81 opened this issue Dec 7, 2018 · 6 comments · Fixed by #33823
Labels
Milestone

Comments

@PVince81
Copy link
Contributor

PVince81 commented Dec 7, 2018

Steps

  1. Create a user "user1"
  2. Set an email address, for example "vincent@local.tld"
  3. Create a file "test.txt"
  4. Log out
  5. Lock the file using the email address as login: curl -u vincent@local.tld:test -X LOCK http://localhost/owncloud/remote.php/webdav/test.txt -d "<?xml version='1.0' encoding='UTF-8'?><d:lockinfo xmlns:d='DAV:'> <d:lockscope><d:shared/></d:lockscope></d:lockinfo>"
  6. Query the lock discovery structure with a PROPFIND (see Feature/webdav locking frontend #32250)

Expected result

lockowner is defined

Actual result

lockowner is empty.

Version

master ac0f01b

@DeepDiver1975 FYI

@PVince81 PVince81 added this to the backlog milestone Dec 7, 2018
@PVince81
Copy link
Contributor Author

PVince81 commented Dec 7, 2018

also happens when using "user1" user but said user has an email address set...

@PVince81
Copy link
Contributor Author

PVince81 commented Dec 7, 2018

seems something is wrong with the serializer... because the owner string is user1 <vincent@local.tld>, it seems to be tripping on the special chars and makes that an empty element...

I'll replace those with parenthesis for now...

@PVince81
Copy link
Contributor Author

PVince81 commented Dec 7, 2018

yup, works with parenthesis

@PVince81
Copy link
Contributor Author

PVince81 commented Dec 7, 2018

hmmm but so this means the Sabre serializer doesn't encode/escape the value ?? this could cause other kind of issues for fancy user names

@PVince81 PVince81 modified the milestones: backlog, development Dec 7, 2018
@PVince81
Copy link
Contributor Author

PVince81 commented Dec 7, 2018

Fix is here: #33823

  • TODO: raise and investigate Sabre issue

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #23865 (missing email template), #22304 (Missing spinner, when creating a share), #2927 (log in with email address), #32385 ([master] no confirmation email when changing own email address), and #32667 (tests to create users by supplying and email address an no password - test infrastructure).

@PVince81 PVince81 modified the milestones: development, QA Jan 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants