[FR] Global user and group medial search boolean option

[tomneedham]

we have accounts.enable_medial_search but we should move to one option respected globally for users, and one for groups, making the results more consistent.

Eg: custom groups backend
Eg: local groups backend
Eg: local user backend
Eg: ldap user backend

[tomneedham]

@pmaier1 @PVince81

[pmaier1]

Maybe we should just disable medial search for groups until we have the groups table instead of adding config options?

[PVince81]

ref: #27623

[PVince81]

disabling permanently could impair the UX for people to whom UX is more important than performance.

let's have this as a config.php only option

[PVince81]

@tomneedham if I understand correctly you mean we need two options:

• "accounts.enable_medial_search_users": affects local, ldap and any other user backends
• "accounts.enable_medial_search_groups": affects ldap group backend, custom groups, etc

now the groups option is not related to the "accounts" table.

what to do with the existing option, migrate it to the other two ? not possible in read-only config.php. we could state this change in release notes for admins to adjust.

[tomneedham]

Move to new config options with better naming. Don't try 'auto migrate' them. We can document in release notes and normal documentation. Side effects are minimal / not critical at all. Easily changed.

[karakayasemi]

@tomneedham @PVince81 Please, correct me if I'm wrong. I'm planning to do the followings.

• Seperate 'accounts.enable_medial_search' as 'accounts.enable_medial_search_users' and 'accounts.enable_medial_search_groups' in sample.config.php.

• Change 'accounts.enable_medial_search' usages to 'accounts.enable_medial_search_users' in all repositories. Also, there is 'user_ldap.enable_medial_search' option in config.apps.sample.php I will remove this option and use new 'accounts.enable_medial_search_users' option instead of this.

• Currently, the implemented group search in the core is using medial search unconditionally. I will add 'accounts.enable_medial_search_groups' check to determine search type in group search methods like here: https://github.com/owncloud/core/blob/master/lib/private/Group/Database.php#L289. Also, I will check other group backend implementations to use this new option.

[tomneedham]

* Seperate 'accounts.enable_medial_search' as  'accounts.enable_medial_search_users' and  'accounts.enable_medial_search_groups' in sample.config.php.

Accounts represent users from a backend. We should keep this named as this.

* Change 'accounts.enable_medial_search' usages to  'accounts.enable_medial_search_users' in all repositories. Also, there is 'user_ldap.enable_medial_search' option in config.apps.sample.php I will remove this option and use new 'accounts.enable_medial_search_users' option instead of this.

The accounts.enable_medial_search is fine - group ones should be called groups.enable_medial_search and then when central group table is merged, we can use it there as well.

Also, there is 'user_ldap.enable_medial_search' option in config.apps.sample.php

We should see where this is used. The key thing should be that within ownCloud - all account searches are only hitting the database so we have control over the expectations for the search time. I would not bring LDAP into this if we can. We might be able to leave this separated for now.

[tomneedham]

@karakayasemi Do you want to have a quick call Monday morning about this? I can explain some background

[karakayasemi]

@tomneedham thank you for help, I read other related issues and patches. After your last explanations, I believe I got the idea for implementing necessities. We can move user_ldap part out of this issue's scope.
I am planning to open a pull request at the weekend. We can discuss further details on the PR. If we need, we can have a chat on rocket.chat or arrange a quick call.