[stable10] Backport of Add regex for shared object file names #34082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add regular expression for shared object file name. The file name can be for example 'a.so' or 'a.so.0.0.1'. So this regular expression would help us to figure out that file has 'so' extension too. Signed-off-by: Sujith H <sharidasan@owncloud.com>
…mac) Add mime type for shared lib extnesion dylib. dylib extension is required for MacOS. Signed-off-by: Sujith H <sharidasan@owncloud.com>
|
Original PR #33894 |
10 tasks
Codecov Report
@@ Coverage Diff @@
## stable10 #34082 +/- ##
==============================================
+ Coverage 63.56% 63.57% +<.01%
- Complexity 19109 19115 +6
==============================================
Files 1264 1264
Lines 75147 75153 +6
Branches 1286 1286
==============================================
+ Hits 47770 47776 +6
Misses 27001 27001
Partials 376 376
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #34082 +/- ##
==============================================
+ Coverage 63.56% 63.57% +<.01%
- Complexity 19109 19115 +6
==============================================
Files 1264 1264
Lines 75147 75153 +6
Branches 1286 1286
==============================================
+ Hits 47770 47776 +6
Misses 27001 27001
Partials 376 376
Continue to review full report at Codecov.
|
delete-merged-branch
bot
deleted the
regex-for-sharedobject-file-stable10
branch
This was referenced Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change in this PR adds regular expression which would consider shared object file with extension not just
.so. We should also consider files with extension sayfoo.so.1.2orfoo.1.2.soorfoo.soorfoo.so.. The regular expression change acheives this.Related Issue
Motivation and Context
The extensions added to
resources/config/mimetypemapping.dist.jsonwould only help for files with single extension. But for the shared object files in GNU/Linux we may have.so,.so.1.2,.1.2.so. For this we need a regular expression in the Detection.php to fix the problem of multiple extension.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: