Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require the testing app to be in the apps folder #34194

Closed
phil-davis opened this issue Jan 21, 2019 · 2 comments
Closed

Do not require the testing app to be in the apps folder #34194

phil-davis opened this issue Jan 21, 2019 · 2 comments
Labels

Comments

@phil-davis
Copy link
Contributor

The acceptance tests assume that the testing app is installed in the apps folder.

We want to be more flexible and let it also be installed in a secondary folder that is listed in apps_paths in config.php

Developers (me) might want to do this. e.g. because they want the local apps folder to be "clean" and only contain the apps that are provided in the core repo.

That can be useful, e.g. when locally running code analysis utilities like make test-php-phan - we want it to just analyze code that really is part of the core repo.

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #22485 (test), #31579 (test), #22492 (test), #23803 (Can't enable app through category if app folder exists, but app has not been enabled yet), and #4424 (Cannot get multiple app folders/repos to work.).

@phil-davis
Copy link
Contributor Author

Fixed by PR #34193

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants