Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Add ownCloud motto change password email #34498

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Conversation

karakayasemi
Copy link
Contributor

Backport of #34470

Description

  • Added the motto as footer
  • Added alternative Plain text page for notify email
  • Update notify email with html template.

@karakayasemi karakayasemi self-assigned this Feb 15, 2019
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #34498 into stable10 will increase coverage by <.01%.
The diff coverage is 73.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34498      +/-   ##
==============================================
+ Coverage        63.6%    63.6%   +<.01%     
  Complexity      19091    19091              
==============================================
  Files            1264     1265       +1     
  Lines           75303    75315      +12     
  Branches         1291     1291              
==============================================
+ Hits            47897    47906       +9     
- Misses          27026    27029       +3     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.71% <73.33%> (ø) 19091 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
settings/ChangePassword/Controller.php 0% <0%> (ø) 33 <0> (ø) ⬇️
core/Controller/LostController.php 88.97% <100%> (+0.24%) 33 <0> (ø) ⬇️
core/templates/lostpassword/notify.php 100% <100%> (ø) 0 <0> (ø) ⬇️
core/templates/lostpassword/altnotify.php 100% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc04927...d5d4776. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #34498 into stable10 will increase coverage by <.01%.
The diff coverage is 73.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34498      +/-   ##
==============================================
+ Coverage        63.6%    63.6%   +<.01%     
  Complexity      19091    19091              
==============================================
  Files            1264     1265       +1     
  Lines           75303    75315      +12     
  Branches         1291     1291              
==============================================
+ Hits            47897    47906       +9     
- Misses          27026    27029       +3     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.71% <73.33%> (ø) 19091 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
settings/ChangePassword/Controller.php 0% <0%> (ø) 33 <0> (ø) ⬇️
core/Controller/LostController.php 88.97% <100%> (+0.24%) 33 <0> (ø) ⬇️
core/templates/lostpassword/notify.php 100% <100%> (ø) 0 <0> (ø) ⬇️
core/templates/lostpassword/altnotify.php 100% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc04927...d5d4776. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit b8af5e4 into stable10 Feb 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport-34470 branch February 15, 2019 13:40
@PVince81
Copy link
Contributor

@pmaier1 relevant for release notes as we should notify admins to adjust their mail templates if applicable

@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants