Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Bump symfony v3.4.22 => v3.4.23 #34663

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

phil-davis
Copy link
Contributor

Description

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 8 updates, 0 removals
  - Updating symfony/debug (v3.4.22 => v3.4.23): Loading from cache
  - Updating symfony/console (v3.4.22 => v3.4.23): Loading from cache
  - Updating symfony/event-dispatcher (v3.4.22 => v3.4.23): Loading from cache
  - Updating symfony/routing (v3.4.22 => v3.4.23): Loading from cache
  - Updating symfony/process (v3.4.22 => v3.4.23): Loading from cache
  - Updating symfony/translation (v3.4.22 => v3.4.23): Loading from cache
  - Updating symfony/yaml (v3.4.22 => v3.4.23): Loading from cache

https://symfony.com/blog/symfony-3-4-23-released

Motivation and Context

Update all the symfony components before the bot makes a pile of PRs.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

master PR is #34662

@phil-davis phil-davis mentioned this pull request Mar 4, 2019
11 tasks
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #34663 into stable10 will decrease coverage by 2.6%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34663      +/-   ##
==============================================
- Coverage       66.61%      64%   -2.61%     
+ Complexity      19409    19246     -163     
==============================================
  Files            1162     1276     +114     
  Lines           64738    75793   +11055     
  Branches            0     1291    +1291     
==============================================
+ Hits            43127    48515    +5388     
- Misses          21611    26899    +5288     
- Partials            0      379     +379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (?) 0 <ø> (?)
#phpunit 65.16% <ø> (-1.46%) 19246 <ø> (-163)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.84% <0%> (-9.39%) 62% <0%> (ø)
lib/private/Files/Storage/DAV.php 81.09% <0%> (-7.78%) 0% <0%> (-161%)
lib/private/DB/AdapterOCI8.php 86.66% <0%> (-6.2%) 4% <0%> (ø)
lib/private/DB/OracleConnection.php 66.66% <0%> (-1.91%) 12% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 85.18% <0%> (-1.61%) 18% <0%> (ø)
apps/files_external/lib/Command/Backends.php 0% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_external/lib/Lib/Backend/DAV.php 0% <0%> (ø) 0% <0%> (?)
core/js/sharedialogexpirationview.js 76.56% <0%> (ø) 0% <0%> (?)
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87240fd...93a1b22. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 30ea263 into stable10 Mar 4, 2019
@PVince81 PVince81 deleted the stable10-symfony-v3.4.23 branch March 4, 2019 11:38
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants