Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] bump dependencies #34755

Merged
merged 6 commits into from
Mar 13, 2019
Merged

[stable10] bump dependencies #34755

merged 6 commits into from
Mar 13, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 13, 2019

Description

Bump dependencies in stable10 to be like what is used in master:

  1. Bump jeremeamia/superclosure (2.1.0 => 2.4.0)
composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 2 installs, 1 update, 0 removals
  - Installing symfony/polyfill-util (v1.10.0): Loading from cache
  - Installing symfony/polyfill-php56 (v1.10.0): Loading from cache
  - Updating jeremeamia/superclosure (2.1.0 => 2.4.0): Loading from cache
  1. Bump nikic/php-parser (v1.4.1 => v4.2.1)
composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Updating nikic/php-parser (v1.4.1 => v4.2.1): Loading from cache
  1. Backport update PHP parser changes from PR 31926

  2. Remove symfony/polyfill-php70 (v1.10.0)

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 0 updates, 2 removals
  - Removing paragonie/random_compat (v9.99.99)
  - Removing symfony/polyfill-php70 (v1.10.0)
  1. Bump swiftmailer/swiftmailer (v5.4.12 => v6.2.0)
composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 4 installs, 1 update, 0 removals
  - Installing symfony/polyfill-php72 (v1.10.0): Loading from cache
  - Installing symfony/polyfill-intl-idn (v1.10.0): Loading from cache
  - Installing symfony/polyfill-iconv (v1.10.0): Loading from cache
  - Installing egulias/email-validator (2.1.7): Loading from cache
  - Updating swiftmailer/swiftmailer (v5.4.12 => v6.2.0): Loading from cache
  1. Backport "Adopt to Swift Mail v6"

Related Issue

Motivation and Context

Get dependencies up-to-date after PHP 5.6 support was dropped in #34698

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #34755 into stable10 will increase coverage by <.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34755      +/-   ##
==============================================
+ Coverage       64.19%   64.19%   +<.01%     
+ Complexity      19887    19883       -4     
==============================================
  Files            1278     1278              
  Lines           76244    76237       -7     
  Branches         1291     1291              
==============================================
- Hits            48943    48942       -1     
+ Misses          26922    26916       -6     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <77.77%> (ø) 19883 <0> (-4) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/App/CodeChecker/CodeChecker.php 41.66% <100%> (ø) 12 <0> (ø) ⬇️
lib/private/Mail/Mailer.php 76.71% <75%> (+0.16%) 22 <0> (-4) ⬇️
lib/private/Server.php 86.65% <0%> (+0.11%) 253% <0%> (ø) ⬇️
...eratedfilesharing/lib/Controller/OcmController.php 66.26% <0%> (+0.2%) 30% <0%> (ø) ⬇️
lib/private/App/CodeChecker/NodeVisitor.php 95.86% <0%> (+0.82%) 54% <0%> (ø) ⬇️
apps/encryption/lib/Session.php 100% <0%> (+1.96%) 22% <0%> (ø) ⬇️
apps/encryption/templates/settings-admin.php 94.11% <0%> (+5.88%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9948ea2...5a62c60. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I hope email test coverage is high enough to guarantee that it still works...

@PVince81 PVince81 merged commit c146ac5 into stable10 Mar 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-bump-dependencies branch March 13, 2019 15:15
@phil-davis
Copy link
Contributor Author

There are acceptance tests for various email sending on changing password, public link sharing...
So that should give good confidence that the email interfaces are OK.

@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants