Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Bump @bower_components/bootstrap from 3.3.6 to 3.3.7 in /build #34843

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

phil-davis
Copy link
Contributor

Description

Bump @bower_components/bootstrap from 3.3.6 to 3.3.7

"the bot" has PRs to bump this to 4.3.1
master PR #34540
stable10 PR #34544

those can be reviewed/tested in slow time.

For now it should be easy to just do this patch version bump to stable10

Motivation and Context

Get dependencies matching in master and stable10

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #34843 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34843   +/-   ##
===========================================
  Coverage       64.23%   64.23%           
  Complexity      19901    19901           
===========================================
  Files            1277     1277           
  Lines           76270    76270           
  Branches         1292     1292           
===========================================
  Hits            48993    48993           
  Misses          26898    26898           
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <ø> (ø) 19901 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c0ed3...2f612a9. Read the comment docs.

@phil-davis phil-davis force-pushed the stable10-bump-bower_components-bootstrap-3.3.7 branch from 51e1c0f to ee8d721 Compare March 24, 2019 06:07
@PVince81
Copy link
Contributor

@dependabot recreate

@phil-davis
Copy link
Contributor Author

The bot might not want to recreate my PR. I will look, rebase...

@phil-davis phil-davis force-pushed the stable10-bump-bower_components-bootstrap-3.3.7 branch from ee8d721 to 2f612a9 Compare March 25, 2019 09:03
@phil-davis
Copy link
Contributor Author

Rebased and ready for review again.

@PVince81 PVince81 merged commit fac9c28 into stable10 Mar 26, 2019
@PVince81 PVince81 deleted the stable10-bump-bower_components-bootstrap-3.3.7 branch March 26, 2019 15:47
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants