Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] [PR 34898] Add the apps-external directory during setup only #34902

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Mar 26, 2019

Description

Backport of PR #34898

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #34902 into stable10 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34902      +/-   ##
==============================================
- Coverage       64.23%   64.22%   -0.01%     
- Complexity      19901    19905       +4     
==============================================
  Files            1277     1277              
  Lines           76270    76277       +7     
  Branches         1292     1292              
==============================================
- Hits            48993    48991       -2     
- Misses          26898    26907       +9     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.39% <0%> (-0.01%) 19905 <0> (+4)
Impacted Files Coverage Δ Complexity Δ
lib/private/Setup.php 24.89% <0%> (-0.78%) 57 <0> (+4)
apps/files_trashbin/lib/Expiration.php 96.55% <0%> (-1.73%) 29% <0%> (ø)
lib/private/Server.php 86.53% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac9c28...e10f7b7. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 5e0030d into stable10 Mar 28, 2019
@PVince81 PVince81 deleted the stable10-22190c9-34898 branch March 28, 2019 09:09
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants