Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App manager not respecting writable flag when folder writable on disk #35031

Closed
PVince81 opened this issue Apr 16, 2019 · 0 comments · Fixed by #35072
Closed

App manager not respecting writable flag when folder writable on disk #35031

PVince81 opened this issue Apr 16, 2019 · 0 comments · Fixed by #35072
Assignees
Labels
p2-high Escalation, on top of current planning, release blocker Type:Bug
Milestone

Comments

@PVince81
Copy link
Contributor

Steps

  1. Setup ownCloud 10.2.0 RC1 enterprise complete which comes with files_pdfviewer 0.10.0 bundled
  2. Check that two folders "apps" and "apps-external" exist.
  3. Check that config.php states that "apps" is not writable, but leave the folder writable on disk
  4. Use market app to update files_pdfviewer to 0.11.0

Expected result

Updated files_pdfviewer lands in "apps-external".

Actual result

Updated files_pdfviewer lands in "apps" despite the folder being marked non-writable in config.

Version

ownCloud enterprise complete 10.2.0 RC1

I suspect that the code is only checking the permissions on disk, not the actual writable flag.
This defeats the purpose of the "apps-external" folder which is supposed to be the recipient for any app updates.

FYI @mmattel @VicDeo

@PVince81 PVince81 added Type:Bug p2-high Escalation, on top of current planning, release blocker labels Apr 16, 2019
@PVince81 PVince81 added this to the QA milestone Apr 16, 2019
@PVince81 PVince81 changed the title App manager not respecting writable flag App manager not respecting writable flag when folder writable on disk Apr 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants