Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.2.0] share attribute required feature #35095

Merged

Conversation

PVince81
Copy link
Contributor

Backport of #35016 to release-10.2.0

@PVince81 PVince81 added this to the QA milestone Apr 25, 2019
@PVince81
Copy link
Contributor Author

@mrow4a please have a look and fix.

it seems you might have been using a jquery function that only exists in newer jquery on master

@patrickjahns
Copy link
Contributor

I believe we should have this ready for RC2 - @mrow4a @DeepDiver1975

@mrow4a
Copy link
Contributor

mrow4a commented Apr 29, 2019

@mrow4a mrow4a force-pushed the release-10.2.0-share_attribute_required_feature branch from 5583f03 to ff36799 Compare April 29, 2019 17:05
@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #35095 into release-10.2.0 will increase coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35095      +/-   ##
====================================================
+ Coverage             64.32%   65.49%   +1.17%     
+ Complexity            20049    20044       -5     
====================================================
  Files                  1285     1222      -63     
  Lines                 76845    69452    -7393     
  Branches               1307        0    -1307     
====================================================
- Hits                  49427    45489    -3938     
+ Misses                27037    23963    -3074     
+ Partials                381        0     -381
Flag Coverage Δ Complexity Δ
#javascript ? ?
#phpunit 65.49% <ø> (-0.03%) 20044 <ø> (-5)
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Capabilities.php 0% <0%> (-100%) 2% <0%> (ø)
lib/private/AllConfig.php 94.52% <0%> (-1.37%) 43% <0%> (ø)
lib/private/legacy/app.php 62.13% <0%> (-1.32%) 174% <0%> (-5%)
lib/private/Installer.php 48.18% <0%> (ø) 85% <0%> (ø) ⬇️
core/js/oc-dialogs.js
core/js/oc-backbone.js
settings/js/admin-apps.js
core/js/config.js
apps/files_sharing/js/external.js
apps/comments/js/commentmodel.js
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bf52c...ff36799. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #35095 into release-10.2.0 will increase coverage by 0.06%.
The diff coverage is 88.46%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35095      +/-   ##
====================================================
+ Coverage             64.32%   64.38%   +0.06%     
  Complexity            20049    20049              
====================================================
  Files                  1285     1285              
  Lines                 76845    76851       +6     
  Branches               1307     1308       +1     
====================================================
+ Hits                  49427    49478      +51     
+ Misses                27037    26989      -48     
- Partials                381      384       +3
Flag Coverage Δ Complexity Δ
#javascript 53.66% <88.46%> (+0.64%) 0 <0> (ø) ⬇️
#phpunit 65.52% <ø> (ø) 20049 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialogshareelistview.js 80.48% <66.66%> (+4.25%) 0 <0> (ø) ⬇️
core/js/shareitemmodel.js 80% <91.3%> (+12.23%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bf52c...98e77f0. Read the comment docs.

@mrow4a mrow4a force-pushed the release-10.2.0-share_attribute_required_feature branch from ff36799 to eafda7d Compare April 29, 2019 18:26
@mrow4a mrow4a force-pushed the release-10.2.0-share_attribute_required_feature branch from eafda7d to 98e77f0 Compare April 29, 2019 20:09
@PVince81
Copy link
Contributor Author

additional changes look good 👍

@PVince81 PVince81 merged commit 5c9e26c into release-10.2.0 Apr 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the release-10.2.0-share_attribute_required_feature branch April 30, 2019 08:32
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants