-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.2.0] share attribute required feature #35095
[10.2.0] share attribute required feature #35095
Conversation
@mrow4a please have a look and fix. it seems you might have been using a jquery function that only exists in newer jquery on master |
I believe we should have this ready for RC2 - @mrow4a @DeepDiver1975 |
5583f03
to
ff36799
Compare
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35095 +/- ##
====================================================
+ Coverage 64.32% 65.49% +1.17%
+ Complexity 20049 20044 -5
====================================================
Files 1285 1222 -63
Lines 76845 69452 -7393
Branches 1307 0 -1307
====================================================
- Hits 49427 45489 -3938
+ Misses 27037 23963 -3074
+ Partials 381 0 -381
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35095 +/- ##
====================================================
+ Coverage 64.32% 64.38% +0.06%
Complexity 20049 20049
====================================================
Files 1285 1285
Lines 76845 76851 +6
Branches 1307 1308 +1
====================================================
+ Hits 49427 49478 +51
+ Misses 27037 26989 -48
- Partials 381 384 +3
Continue to review full report at Codecov.
|
ff36799
to
eafda7d
Compare
eafda7d
to
98e77f0
Compare
additional changes look good 👍 |
Backport of #35016 to release-10.2.0