Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.2.0] add new capability privateLinksDetailsParam #35104

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Conversation

karakayasemi
Copy link
Contributor

Backport of #35101

Description

add capability entry for this feature: #32152

Related Issue

Motivation and Context

Show clients whether this feature #32152 is supported or not.

How Has This Been Tested?

Unit tests added, also tested via ocs rest api for capabilities.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #35104 into release-10.2.0 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35104      +/-   ##
====================================================
+ Coverage             64.29%   64.31%   +0.01%     
  Complexity            20044    20044              
====================================================
  Files                  1285     1285              
  Lines                 76846    76837       -9     
  Branches               1307     1307              
====================================================
+ Hits                  49410    49414       +4     
+ Misses                27055    27042      -13     
  Partials                381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.51% <ø> (+0.01%) 20044 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Capabilities.php 100% <ø> (+100%) 2 <0> (ø) ⬇️
lib/private/Server.php 86.54% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73beb5d...37abcee. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 40ea331 into release-10.2.0 Apr 26, 2019
@PVince81 PVince81 deleted the bp-35101 branch April 26, 2019 14:07
@PVince81 PVince81 added this to the QA milestone May 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants