Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.2.0] Backport of dont show notification if federated share auto… #35135

Merged
merged 1 commit into from
May 2, 2019

Conversation

sharidas
Copy link
Contributor

@sharidas sharidas commented May 2, 2019

…accepted

Description

No need to show a notification if federated share auto-accepted.

Related Issue

Motivation and Context

No need to show a notification if federated share auto-accepted.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@sharidas sharidas added this to the development milestone May 2, 2019
@sharidas sharidas self-assigned this May 2, 2019
@sharidas sharidas requested review from PVince81 and VicDeo May 2, 2019 06:31
@sharidas
Copy link
Contributor Author

sharidas commented May 2, 2019

Original PR #35132

@sharidas sharidas changed the title [stable10] Backport of dont show notification if federated share auto… [10.2.0] Backport of dont show notification if federated share auto… May 2, 2019
@sharidas sharidas force-pushed the fix-fed-not-release-10.2.0 branch from 0068ef9 to dabfab2 Compare May 2, 2019 06:34
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #35135 into release-10.2.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35135      +/-   ##
====================================================
+ Coverage             64.38%   64.38%   +<.01%     
- Complexity            20049    20050       +1     
====================================================
  Files                  1285     1285              
  Lines                 76851    76853       +2     
  Branches               1308     1308              
====================================================
+ Hits                  49478    49481       +3     
+ Misses                26989    26988       -1     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.52% <100%> (ø) 20050 <4> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/federatedfilesharing/lib/FedShareManager.php 80.37% <100%> (+0.25%) 25 <0> (+1) ⬆️
...ederatedfilesharing/lib/FederatedShareProvider.php 61.13% <100%> (ø) 85 <4> (ø) ⬇️
lib/private/Server.php 86.66% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9e26c...dabfab2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #35135 into release-10.2.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35135      +/-   ##
====================================================
+ Coverage             64.38%   64.38%   +<.01%     
- Complexity            20049    20050       +1     
====================================================
  Files                  1285     1285              
  Lines                 76851    76853       +2     
  Branches               1308     1308              
====================================================
+ Hits                  49478    49481       +3     
+ Misses                26989    26988       -1     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.52% <100%> (ø) 20050 <4> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/federatedfilesharing/lib/FedShareManager.php 80.37% <100%> (+0.25%) 25 <0> (+1) ⬆️
...ederatedfilesharing/lib/FederatedShareProvider.php 61.13% <100%> (ø) 85 <4> (ø) ⬇️
lib/private/Server.php 86.66% <0%> (+0.11%) 253% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9e26c...dabfab2. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit b4ca957 into release-10.2.0 May 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-fed-not-release-10.2.0 branch May 2, 2019 09:15
@PVince81 PVince81 modified the milestones: development, QA May 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants