Duplicate link share entry in OCS response with favorites

[PVince81]

Steps

1. Create a folder "test"
2. Create three link shares with different names for that folder
3. Mark folder as favorite
4. Go to "Shared with link"
5. Observe the network console for "/ocs/v1.php/apps/files_sharing/api/v1/shares?format=json&include_tags=true"

Expected result

Three share entries with different ids, each corresponding to the three link shares.

Actual result

Three identical share entries, all with the same id

Version

ownCloud 10.4.1 pre-alpha from git master 433ba3e

I suspect that this is a very old bug and never got discovered before. Probably related to the way how "include_tags" is working to inject the favorite information which is considered a tag, the problem will likely happen as well when setting tags on the entry.

[PVince81]

It seems it also happens even when setting "include_tags" to false which we have in Phoenix.
I'd have expected that the tags logic gets disabled there.