Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requesting a file preview with an ivalid size results in HTTP error 500 #37165

Closed
individual-it opened this issue Mar 25, 2020 · 4 comments · Fixed by #37173
Closed

requesting a file preview with an ivalid size results in HTTP error 500 #37165

individual-it opened this issue Mar 25, 2020 · 4 comments · Fixed by #37173
Assignees
@DeepDiver1975
Labels
Type:Bug

Comments

@individual-it
Copy link
Member

Steps to reproduce

  1. request a preview with size 0 e.g. curl '172.17.0.1/owncloud-core/remote.php/dav/files/admin/lorem.txt?x=0&y=320&forceIcon=1&preview=1' -u admin:admin -v

Expected behaviour

HTTP code 400 - Bad Request

Actual behaviour

HTTP code 500 - Internal Server error
@phil-davis
Copy link
Contributor

What about x=-1 x=1.5 x=abc ? :)

@individual-it
Copy link
Member Author

What about x=-1 x=1.5 x=abc ? :)

on it #37166

@DeepDiver1975 DeepDiver1975 self-assigned this Mar 26, 2020
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Mar 26, 2020 •
edited
Loading

Which version is this? I'm getting a 404 on master

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Mar 26, 2020 •
edited
Loading

is there an error in the log file? http 500 should write something into the logs

@DeepDiver1975 DeepDiver1975 mentioned this issue Mar 26, 2020
Merged
11 tasks
@davitol davitol mentioned this issue Mar 31, 2020
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeepDiver1975 DeepDiver1975

Labels
Type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply proper error handling for unsupported file types and errors dur… owncloud/core
3 participants
@DeepDiver1975 @phil-davis @individual-it