Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File looks like it can be copied from received share and exceed quota #40140

Closed
phil-davis opened this issue Jun 14, 2022 · 3 comments · Fixed by #39895
Closed

File looks like it can be copied from received share and exceed quota #40140

phil-davis opened this issue Jun 14, 2022 · 3 comments · Fixed by #39895

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Jun 14, 2022

Steps to reproduce

  1. Alice has some storage quota, Brian has zero or low quota
  2. Alice shares a file with Brian, or a folder containing a file
  3. Brian copies the received file to his own home storage

Expected behaviour

The API copy request should fail with a suitable HTTP response status like 507 "insufficient storage".

Actual behaviour

The HTTP status is 201 - to the client it seems that the copy was successful.
But actually the copied file does not exist. It seems that the copy did not really happen.

Server configuration

Current core master - see demonstration test scenarios

@phil-davis phil-davis changed the title File can be copied from received share and exceed quota File looks like it can be copied from received share and exceed quota Jun 14, 2022
@phil-davis
Copy link
Contributor Author

Demonstration tests are added in PR #40141

@phil-davis
Copy link
Contributor Author

The same problem happens in the reverse direction:

Steps to reproduce

  1. Alice has zero or low storage quota, Brian has enough quota
  2. Alice shares a file or folder with Brian
  3. Brian copies a file from his own home storage to the share received from Alice

Expected behaviour

The API copy request should fail with a suitable HTTP response status like 507 "insufficient storage".

Actual behaviour

The HTTP status is 201 or 204 - to the client it seems that the copy was successful.
But actually the copied file does not exist. It seems that the copy did not really happen.

Server configuration

Current core master - see demonstration test scenarios

@phil-davis
Copy link
Contributor Author

Note: when the encryption app is enabled and encryption is happening, it seems that, as well as getting a success HTTP 2xx status, the file content actually gets written to storage and the quota is exceeded. See test scenarios added by encryption PR owncloud/encryption#346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant