Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc-1782 - "Strange" characters not allowed in group names #799

Closed
msrex opened this issue Dec 9, 2012 · 7 comments
Closed

oc-1782 - "Strange" characters not allowed in group names #799

msrex opened this issue Dec 9, 2012 · 7 comments
Labels

Comments

@msrex
Copy link

msrex commented Dec 9, 2012

From http://bugs.owncloud.org/thebuggenie/owncloud/issues/oc-1782

Behaviour in v4.5.4: you can create the group, it is displayed correctly at first, then after re-login you see "šola" instead of "šola". If we don't want non-ASCII-characters as user or group names, we should not allow the creation.
This is independent of the database backend used.

Description:
Tested on owncloud-4.5.0-beta3.tar.bz2 (ownCloud 4.5 beta 3a) and ownCloud 4.5 beta 4.

Reproduction steps:
Settings -> Users The names of groups cannot have "strange" characters like ščžć in them. If I try to add a group named šola (school in Slovenian), it gets deleted after a page refresh.

I am using My SQL as the database backend.

1Comment posted by blizzz Sep 19, 09:11

Actually, it is not a bug. Only a limited set of Ascii characters is intentionally allowed for user and group names(, yet).
#3 Comment posted by 5er Sep 19, 14:00

I am fine with it. I think it would than be better to not create a group in the first place. (Maybe with an warning about ASCII characters.) It can be a little annoying to create groups and assign users to them only to see all the work done vanish after a page refresh.
#5 Comment posted by MTRichards Oct 22, 18:22

Agreed - if it is not allowed, it should not be allowed to be created...

@msrex
Copy link
Author

msrex commented Dec 10, 2012

Same as owncloud-archive/apps#322

@jancborchardt
Copy link
Member

Rather than not allowing and outright preventing the group creation, how about converting the »strange« characters into normal ones automatically. So ščžć would simply be sczc. We could even show a notification like »Unsupported characters in the name were automatically replaced«.

@DeepDiver1975
Copy link
Member

Hmm in 2012 it should be possible to use proper encodings ;-)
Or did I miss anything?

@karlitschek
Copy link
Contributor

Agreed. Proper encoding should fix that. No need to not allow special characters here.

This is different for usernames by the way. We have to make sure that usernames work for all the other systems that we integrate with ownCloud so a restriction to more "standard" characters make sense there

@msrex
Copy link
Author

msrex commented Dec 16, 2012

So I tested some more, and in the current implementation it is impossible to remove a user from a group that contains a "special character". Instead a new group is created each time uncheck the offending group. This needs to be fixed still in the v4.5 tree, as there is no workaround for a user if he accidentally entered a wrong character.

Reproduction:

  1. create a user
  2. create a group with a strange character (e.g. ßz)
  3. assign the user to that group ßz
  4. you'll see it represented as ß
  5. try to remove the user from that group
    => you'll see the group doubled up to "ßz, ßz" and the user still assigned to it
    This goes on and on.

@MTGap
Copy link
Contributor

MTGap commented Dec 28, 2012

Numbers shouldn't be allowed in group names, because of PHP's loose typing.

I just had an issue with the external storage that is not fixable, because of a group of just numbers I made for testing.

@bartv2
Copy link
Contributor

bartv2 commented Apr 8, 2013

Tested with OC5, this works now, even numbers

@bartv2 bartv2 closed this as completed Apr 8, 2013
@lock lock bot locked as resolved and limited conversation to collaborators Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants