Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Sharing Behavior Update #9058

Closed
MTRichards opened this issue Jun 16, 2014 · 42 comments
Closed

Re-Sharing Behavior Update #9058

MTRichards opened this issue Jun 16, 2014 · 42 comments

Comments

@MTRichards
Copy link
Contributor

In a future ownCloud release (8?).

As an ownCloud user, I want people with reshare privileges on a file or folder that I have shared with them to be able to reshare that with other users, and I want those "reshared" recipients to appear in my shared to list, so that myself - and everyone that the file is shared with - knows who has access to the file.

This means two things have to happen:

  1. Every user that is a share recipient of a file or folder can see a list of who else has access to the file or folder (which will need to be a setting that can be disabled in the config file for some security related reasons)
    and
  2. That the sharing behavior moves from the current ad hoc re-share chain (which is difficult to search and understand programmatically or as a user) to a scenario where a reshared file or folder recipient is just added to the file or folder owner's "shared with" list.

In short, rather than creating an ad-hoc share using reshare, the user would be adding another person(s) to the file or folder owner's list of "shared with".

This will make it much easier to report on sharing, much faster for the API to allow mobile and desktop (in the future) to make changes to the shares, and makes it much easier on the admin and end user to understand.

@karlitschek
Copy link
Contributor

yes. good point,

@PVince81
Copy link
Contributor

As discussed 👍

@PVince81
Copy link
Contributor

If I remember well we identified some potential difficulties but can't remember right now.
This needs to be thought through, including how the old reshares will be migrated.

@schiessle
Copy link
Contributor

Absolutely, we discussed this already in Stuttgart and I'm in favour of it! This would also make a lot of other stuff much easier! I will put this on my ToDo List 😄

@nickvergessen
Copy link
Contributor

Just came across this while trying to add acitivities for "Resharing".
Will put them on the oC8 list, so I do not have to implement them twice.

@PVince81
Copy link
Contributor

Any update when we want this ?

@PVince81
Copy link
Contributor

Note: if we still don't want to schedule this, there's a bunch of permission propagation issues that will need to be solved then, like #13201
and these fixes will likely to be thrown away afterwards.

@michaelstingl
Copy link

00002404

@MorrisJobke
Copy link
Contributor

cc @craigpg FYI ... @michaelstingl has a request for this feature.

@cdamken
Copy link
Contributor

cdamken commented Feb 4, 2015

@MorrisJobke @MTRichards Is it possible to put it in a milestone? When is planned?

@DeepDiver1975
Copy link
Member

Is it possible to put it in a milestone? When is planned?

I don't see this happen before 8.2 @MTRichards FYI

@MTRichards
Copy link
Contributor Author

No sooner than 8.2, agreed.

@nickvergessen
Copy link
Contributor

so we need a new milestone me hides 🙊

@DeepDiver1975 DeepDiver1975 added this to the 8.2-next milestone Mar 2, 2015
@MTRichards
Copy link
Contributor Author

Now it is an official user request.

@bboule
Copy link

bboule commented Jan 7, 2016

@MTRichards did this make 9 or should we be setting a different expectation?

@MTRichards
Copy link
Contributor Author

Should be in 9.0. We are reworking sharing, thus this should be reflected in it.

@DeepDiver1975
Copy link
Member

@schiesbn let's chat soon-ish about the migration path - THX

@DeepDiver1975
Copy link
Member

@MTRichards do we have any reference database dump to 'play' with? Or at least an understanding how the most complex and biggest installations out there look like - with respect to resharing? THX

@MTRichards
Copy link
Contributor Author

@bboule is your link to our running systems.
@bboule do you have any access to the data?
or @MorrisJobke perhaps there is something from our work with [customer you spent a while on]?

@caratsch
Copy link

@DeepDiver1975 & @MorrisJobke I can provide/send you an actual dump if you want

@rullzer
Copy link
Contributor

rullzer commented Jan 11, 2016

With #20773 in shares created via the OCS endpoint (so soon all shares!) will have the new sharing behaviour. So they are actually shares of the file owner but have the user that shares them as initiator.

@MorrisJobke
Copy link
Contributor

@MTRichards do we have any reference database dump to 'play' with? Or at least an understanding how the most complex and biggest installations out there look like - with respect to resharing? THX

I can check with @caratsch - what do we want to know?

  • shares vs reshares - original folder vs subfolder
  • external shares
  • self-mounted external shares

Anything else?

@PVince81
Copy link
Contributor

Missing pieces to finish this:

@rullzer
Copy link
Contributor

rullzer commented Jan 15, 2016

some OCS API modifications (minimal)

This is basically just adding information about who owns the files. The info is already there in the share object. I just did not yet expose it to the outside world.

@rullzer
Copy link
Contributor

rullzer commented Jan 15, 2016

PR for extending the API #21754

@PVince81
Copy link
Contributor

@rullzer anything left for "re-sharing" behavior update on the code side ?

@rullzer
Copy link
Contributor

rullzer commented Jan 29, 2016

  • Properly fix displaying the new resharing behaviour...

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2016

Properly fix displaying the new resharing behaviour...

@rullzer what about this ?

@rullzer
Copy link
Contributor

rullzer commented Feb 9, 2016

@PVince81 ah crap forgot about that one... let me see what I can do :)

@PVince81
Copy link
Contributor

@rullzer what's left to fix ? I thought it was that tooltip about the initiator but it got shot down.

@rullzer
Copy link
Contributor

rullzer commented Feb 12, 2016

Yes lets close this. This is basically done. The multiple link shares (#22327) that are needed to have this resharing behaviour also for link shares is raised separatly,

Other stuff that comes up now are either bug or new features :)

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests