Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] Update the help links to point to the online documentation #34649

Merged
merged 1 commit into from
Mar 1, 2019
Merged

[stable10] Update the help links to point to the online documentation #34649

merged 1 commit into from
Mar 1, 2019
+12 −10

Conversation

settermjd
Copy link
Contributor

Backporting #34586 to Stable10.

@settermjd settermjd self-assigned this Mar 1, 2019
@settermjd settermjd requested a review from PVince81 March 1, 2019 08:55
@PVince81 PVince81 changed the title Update the help links to point to the online documentation [stable10] Update the help links to point to the online documentation Mar 1, 2019
@PVince81 PVince81 added this to the development milestone Mar 1, 2019
PVince81
PVince81 approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

PVince81 commented Mar 1, 2019

Fixes https://github.com/owncloud/enterprise/issues/3155

@PVince81
Copy link
Contributor

PVince81 commented Mar 1, 2019

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders ownclouders force-pushed the backport-update-help-links-to-the-documentation branch from 43a5d15 to 22f80f1 Compare March 1, 2019 11:24
@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #34649 into stable10 will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34649      +/-   ##
==============================================
- Coverage       64.01%   63.98%   -0.04%     
+ Complexity      19246    19227      -19     
==============================================
  Files            1276     1272       -4     
  Lines           75787    75730      -57     
  Branches         1291     1291              
==============================================
- Hits            48515    48453      -62     
- Misses          26893    26898       +5     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.12% <0%> (-0.04%) 19227 <0> (-19)
Impacted Files Coverage Δ Complexity Δ
settings/templates/help.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/lib/API/Share20OCS.php 93.46% <0%> (-0.02%) 184% <0%> (ø)
apps/files_sharing/appinfo/routes.php 98.5% <0%> (ø) 0% <0%> (ø) ⬇️
apps/files_sharing/lib/Panels/Personal/Section.php
apps/files_sharing/templates/settings-personal.php
...iles_sharing/lib/Panels/Personal/PersonalPanel.php
...ring/lib/Controller/PersonalSettingsController.php

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a276c5...22f80f1. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 1, 2019 •
edited
Loading

Codecov Report

Merging #34649 into stable10 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34649      +/-   ##
==============================================
- Coverage       64.01%      64%   -0.01%     
  Complexity      19246    19246              
==============================================
  Files            1276     1276              
  Lines           75787    75793       +6     
  Branches         1291     1291              
==============================================
  Hits            48515    48515              
- Misses          26893    26899       +6     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.16% <0%> (-0.01%) 19246 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
settings/templates/help.php 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a276c5...22f80f1. Read the comment docs.

@PVince81 PVince81 merged commit 87240fd into stable10 Mar 1, 2019
@PVince81 PVince81 deleted the backport-update-help-links-to-the-documentation branch March 1, 2019 15:00
@phil-davis phil-davis mentioned this pull request Mar 9, 2019
Merged
11 tasks
This was referenced Apr 15, 2019
Closed
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@settermjd settermjd

Labels
4 - To release
Projects
None yet
Milestone
development
Development

Successfully merging this pull request may close these issues.
3 participants
@settermjd @PVince81 @ownclouders