-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design: Content page #74
Comments
@pmaier1 @settermjd what do you think? |
Maybe add the |
@LukasHirt, on the whole, I really like the changes that you've made. I do have four questions, however:
|
@tboerger @settermjd Thank you both for your inputs. I'll work on it again on Friday and will get back to you with the results. |
So I tried to make some changes after your suggestions. I came up with three possible versions. To summarise the changes:
Let me know what do you think about these changes and which of those prototypes should we go with in your opinion. |
I like the 2nd version, with the "edit" button below the TOC. Problem might be, the TOC can be a lengthy list… |
@michaelstingl We could set some max height to the TOC and cut it a little bit in the case of too many items - this way the edit action could still stay visible. Also, this would be probably needed anyway since I would like to have that list fixed when a user is scrolling. |
What prevents in having Edit and Report over TOC, then the TOC list can be long ? |
If the toc is really that large it should be split into multiple pages anyway. Imho it's good to put the edit link below it. For the issue link we could add an attribute per documentation definition, if this isn't already available. Just the style of the version selector is the only thing I don't like that much. |
Design draft for content page of documentation. @tboerger @michaelstingl I tried to bring navigation closer to the style of https://docs.mulesoft.com/general/ as you both recommended. Also is there used directories as mentioned in proposal owncloud/docs#695
I would like to raise a discussion about preserving the breadcrumbs. The previous directories will be already distinguished in the left sidebar navigation so I would like to save a little bit of space and get rid of the annoying problem with alignment between search and breadcrumbs by getting rid of them. Would do you say about that?
The text was updated successfully, but these errors were encountered: