-
Notifications
You must be signed in to change notification settings - Fork 168
Fixed updater CSS/JS in nginx example configuration #2551
Conversation
@Cysioland, thanks for your PR! By analyzing the annotation information on this pull request, we identified @carlaschroder, @RealRancor and @mmattel to be potential reviewers |
cc @josh4trunks as i have no idea about the updater and don't use it Edit Seems to work and won't break anything else. |
Nice catch! I don't use it either and didn't realize there were static assets there to be served as well. I instead recommend we move the updater block (1) to below the static block (2) so static assets are always captured in a single place. This should also be done for the webroot configuration. |
CC @VicDeo FYI |
I applied the fix and nothing changed. If I fully remove the location block regarding updater and ocs-provider the PHP script (e. g. /owncloud/updater) is now executed. So the fix simply doesn´t work (yet). |
Corrected:
|
What is the status of this? Are there any thumbsups, or does it need more review? |
I agree with the change, but believe the updater block should be moved to below the static asset block. |
So lets merge then? I can take over the move of the updater block and the subdir example |
Sure, let's merge. Thanks @RealRancor |
Should I also add my GitHub handle to attribute myself?