Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Fixed updater CSS/JS in nginx example configuration #2551

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

Cysioland
Copy link
Contributor

Should I also add my GitHub handle to attribute myself?

@mention-bot
Copy link

@Cysioland, thanks for your PR! By analyzing the annotation information on this pull request, we identified @carlaschroder, @RealRancor and @mmattel to be potential reviewers

@ghost
Copy link

ghost commented Jul 31, 2016

cc @josh4trunks as i have no idea about the updater and don't use it

Edit

Seems to work and won't break anything else.

@josh4trunks
Copy link
Contributor

Nice catch! I don't use it either and didn't realize there were static assets there to be served as well.

I instead recommend we move the updater block (1) to below the static block (2) so static assets are always captured in a single place.
1 - location ~ ^/(?:updater|ocs-provider)(?:$|/) {
2 - location ~* \.(?:svg|gif|png|html|ttf|woff|ico|jpg|jpeg)$ {

This should also be done for the webroot configuration.

@PVince81
Copy link
Contributor

PVince81 commented Aug 8, 2016

CC @VicDeo FYI

@bcutter
Copy link

bcutter commented Aug 15, 2016

I applied the fix and nothing changed. If I fully remove the location block regarding updater and ocs-provider the PHP script (e. g. /owncloud/updater) is now executed. So the fix simply doesn´t work (yet).

@ghost
Copy link

ghost commented Aug 15, 2016

So the fix simply doesn´t work (yet).

Corrected:

So the fix simply doesn´t work (yet) for me

@carlaschroder
Copy link
Contributor

What is the status of this? Are there any thumbsups, or does it need more review?

@josh4trunks
Copy link
Contributor

I agree with the change, but believe the updater block should be moved to below the static asset block.
Also this should be fixed for the subdir example as well

@ghost
Copy link

ghost commented Sep 18, 2016

So lets merge then? I can take over the move of the updater block and the subdir example

@carlaschroder
Copy link
Contributor

Sure, let's merge. Thanks @RealRancor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants